Skip to content

Generalize reusable Windows CI jobs #121766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugovk merged 5 commits into from
Jul 14, 2024
Merged

Generalize reusable Windows CI jobs #121766

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f8c44ed
🧪💅Evaluate `free-threading` var as JSON @ CI
webknjaz Jul 14, 2024
c2bd0ed
🧪💅 Describe `free-threading` workflow input
webknjaz Jul 14, 2024
4579407
🧪💅 Mv `reusable-windows` workflow `env` to top
webknjaz Jul 14, 2024
a66b4a0
🧪💅 Mv reusable-windows arch matrix outside
webknjaz Jul 14, 2024
21a36a2
🧪💅 Melt (non-)free-threading Win jobs a matrix
webknjaz Jul 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
🧪💅 Mv reusable-windows workflow env to top 
Previously, it was duplicated in each job which is not DRY.
  • Loading branch information
@webknjaz
webknjaz committed Jul 14, 2024
commit 4579407f594d50a486d031f04ce04f09d1548ffd
10 changes: 4 additions & 6 deletions .github/workflows/reusable-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,15 @@ on:
type: boolean
default: false

env:
IncludeUwp: >-
true

jobs:
build_win32:
name: 'build and test (x86)'
runs-on: windows-latest
timeout-minutes: 60
env:
IncludeUwp: 'true'
steps:
- uses: actions/checkout@v4
- name: Build CPython
Expand All @@ -27,8 +29,6 @@ jobs:
name: 'build and test (x64)'
runs-on: windows-latest
timeout-minutes: 60
env:
IncludeUwp: 'true'
steps:
- uses: actions/checkout@v4
- name: Register MSVC problem matcher
Expand All @@ -44,8 +44,6 @@ jobs:
name: 'build (arm64)'
runs-on: windows-latest
timeout-minutes: 60
env:
IncludeUwp: 'true'
steps:
- uses: actions/checkout@v4
- name: Register MSVC problem matcher
Expand Down