Skip to content

gh-121621: Move asyncio running loop to thread state #121695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fidget-Spinner merged 21 commits into from
Jul 16, 2024
Merged

gh-121621: Move asyncio running loop to thread state #121695

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
4822190
Use PyMutex for writes to asyncio state
Fidget-Spinner Jul 11, 2024
143747b
Address review
Fidget-Spinner Jul 12, 2024
580304c
fix default build
Fidget-Spinner Jul 12, 2024
1faed12
Fix typo
Fidget-Spinner Jul 12, 2024
ba3d771
Address review
Fidget-Spinner Jul 12, 2024
ec2c175
fixup whitespace
Fidget-Spinner Jul 12, 2024
e1b730a
minor nit
Fidget-Spinner Jul 12, 2024
f9fb6e1
Move asyncio freelist to per-thread
Fidget-Spinner Jul 13, 2024
c9ac6bb
Move running loop to thread state
Fidget-Spinner Jul 13, 2024
b450b96
Merge remote-tracking branch 'upstream/main' into asyncio_rest_thread…
Fidget-Spinner Jul 14, 2024
3d78e8a
remove freelist changes
Fidget-Spinner Jul 15, 2024
4f03f71
Use just a single threadstate field
Fidget-Spinner Jul 15, 2024
a1ce760
fix whitespace
Fidget-Spinner Jul 15, 2024
f3f1c57
fix stray thing
Fidget-Spinner Jul 15, 2024
4e3c64a
Update comment
Fidget-Spinner Jul 15, 2024
19953a8
Clean up code even more
Fidget-Spinner Jul 15, 2024
ba039ee
make regen-all
Fidget-Spinner Jul 15, 2024
3429231
Partially address review
Fidget-Spinner Jul 16, 2024
c6df89f
Address review
Fidget-Spinner Jul 16, 2024
91438a5
Change Py_None to NULL
Fidget-Spinner Jul 16, 2024
46432e8
add back missing comment
Fidget-Spinner Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
minor nit
  • Loading branch information
@Fidget-Spinner
Fidget-Spinner committed Jul 12, 2024
commit e1b730a0a38e7bbfe691a7c5ae335fdefeb5186b
4 changes: 2 additions & 2 deletions Modules/_asynciomodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2059,7 +2059,7 @@ register_eager_task(asyncio_state *state, PyObject *task)
}

static void
unregister_task_no_lock(asyncio_state *state, TaskObj *task)
unregister_task_lock_held(asyncio_state *state, TaskObj *task)
{
assert(Task_Check(state, task));
assert(task != &state->asyncio_tasks.tail);
Expand All @@ -2085,7 +2085,7 @@ static void
unregister_task(asyncio_state *state, TaskObj *task)
{
ASYNCIO_STATE_LOCK(state);
unregister_task_no_lock(state, task);
unregister_task_lock_held(state, task);
ASYNCIO_STATE_UNLOCK(state);
}

Expand Down