Skip to content

gh-121423: Improve import time of socket by writing socket.errorTab as a constant and lazy import modules #121424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 12 commits into from
Sep 4, 2024
Merged

gh-121423: Improve import time of socket by writing socket.errorTab as a constant and lazy import modules #121424

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
1724a3c
Speed up `socket.errotTab` and lazy import `selectors`
Wulian233 Jul 6, 2024
6559ebb
lint
Wulian233 Jul 6, 2024
984a3b2
typo
Wulian233 Jul 6, 2024
1823c9a
lower().startswith("win")
Wulian233 Jul 6, 2024
dce6cd2
Update Misc/NEWS.d/next/Library/2024-07-06-12-37-10.gh-issue-121423.v…
Wulian233 Jul 7, 2024
276d0bb
lint
Wulian233 Jul 7, 2024
feae2fa
Update Misc/NEWS.d/next/Library/2024-07-06-12-37-10.gh-issue-121423.v…
Wulian233 Jul 7, 2024
bd771c8
comment describing the intentional lazy import
gpshead Aug 31, 2024
fa169f8
Merge branch 'main' into socket
hauntsaninja Sep 2, 2024
1773d04
lazy array
Wulian233 Sep 3, 2024
412a3d2
separate imports
Wulian233 Sep 3, 2024
fa49395
undo 3.14.rst
Wulian233 Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Misc/NEWS.d/next/Library/2024-07-06-12-37-10.gh-issue-121423.v… 
…nxrl4.rst

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
  • Loading branch information
@Wulian233 @picnixz
Wulian233 and picnixz authored Jul 7, 2024
commit feae2fa7dbbe4d88b64396db4f45ddc3d5d7686a
4 changes: 2 additions & 2 deletions Misc/NEWS.d/next/Library/2024-07-06-12-37-10.gh-issue-121423.vnxrl4.rst
View file
Open in desktop

@hugovk hugovk Sep 3, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename to Misc/NEWS.d/next/Library/2024-07-06-12-37-10.gh-issue-118761.vnxrl4.rst (containing gh-issue-118761) and we're ready to merge :)

@vstinner vstinner Sep 4, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#121423 is the right issue.

Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Improve import time of `mod`:`socket` by writing `socket.errorTab` as a
constant and lazy import of `mod`:`selectors`
Improve import time of :mod:`socket` by lazy importing :mod:`selectors` and
writing :data:`!socket.errorTab` as a constant.