Skip to content

gh-121300: Add replace to copy.__all__ #121302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 6 commits into from
Jul 3, 2024
Merged

gh-121300: Add replace to copy.__all__ #121302

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3289006
Add `replace` to `copy.__all__`
max-muoto Jul 3, 2024
0138a94
Merge branch 'main' into add-replace-to-all
max-muoto Jul 3, 2024
4bdb564
Add test case
max-muoto Jul 3, 2024
09a8e59
Update interface docs
max-muoto Jul 3, 2024
2854dfc
Update test_copy.py
max-muoto Jul 3, 2024
49e3338
Merge branch 'main' into add-replace-to-all
max-muoto Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add replace to copy.__all__
  • Loading branch information
@max-muoto
max-muoto committed Jul 3, 2024
commit 32890062181df1f344483d67da9abccad23b576d
2 changes: 1 addition & 1 deletion Lib/copy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ class Error(Exception):
pass
error = Error # backward compatibility

__all__ = ["Error", "copy", "deepcopy"]
__all__ = ["Error", "copy", "deepcopy", "replace"]

@pygeek pygeek Jul 3, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a regression test so this doesn't happen again. See helper method support.test__all__ in the test directory—it automatically detects public methods based on whether they follow the public name convention.

@max-muoto max-muoto Jul 3, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, let me go ahead, good callout.


def copy(x):
"""Shallow copy operation on arbitrary Python objects.
Expand Down