Skip to content

bpo-31904: Add posix module support for VxWorks RTOS #12118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 23 commits into from
May 21, 2019
Merged

bpo-31904: Add posix module support for VxWorks RTOS #12118

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
cce75ba
support posix module on VxWorks
pxinwr Mar 1, 2019
f548045
update clinic for Modules/clinic/posixmodule.c.h
pxinwr Mar 1, 2019
b41b4d0
Run autoreconf
pxinwr Mar 1, 2019
3462991
add news file
pxinwr Mar 1, 2019
8de1134
bpo-31904: Add posix module support for VxWorks RTOS #12118
yuesun1 Mar 6, 2019
7354c9f
add the period mark in the os.rst
pxinwr Mar 8, 2019
8668612
revert aclocal.m4
pxinwr Mar 8, 2019
6f8e048
tune the lines in os.rst
pxinwr Mar 8, 2019
961f435
Merge remote-tracking branch 'upstream/master' into fix-issue-31904-os
pxinwr Mar 18, 2019
86091ad
update Modules/clinic/posixmodule.c.h
pxinwr Mar 18, 2019
5ea0755
Fix os.rst for spawnv() and spawnve() in OS module
yuesun1 Mar 19, 2019
30e9049
Merge remote-tracking branch 'upstream/master' into fix-issue-31904-os
pxinwr May 17, 2019
cf1a844
improve the test_urandom_failure and skip the ExecTests test cases in…
yuesun1 Mar 14, 2019
728165f
Add news file
yuesun1 Mar 14, 2019
36e955f
update clinic for Modules/clinic/posixmodule.c.h
pxinwr May 17, 2019
3716550
skip URandomFDTests in test_os.py for VxWorks
pxinwr May 17, 2019
c14d326
call PyErr_CheckSignals() on EINTR to respect the PEP 475 for waitpid
pxinwr May 17, 2019
a508f47
rephrase VxWorks' behaviour for spawn-like methods
pxinwr May 17, 2019
201212d
improve Doc/library/os.rst for VxWorks special behaviour
pxinwr May 17, 2019
da73b91
remove the separate NEWS entry for test part
pxinwr May 20, 2019
b380c49
add comments for calling rtpSpawn()
pxinwr May 21, 2019
7ada2ad
fix the typo in Doc/library/os.rst
pxinwr May 21, 2019
eb063a8
refine the skip message for ExecTests
pxinwr May 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix os.rst for spawnv() and spawnve() in OS module
  • Loading branch information
@yuesun1
yuesun1 committed Mar 19, 2019
commit 5ea07553f1a3db3635d64979bcdd2759bf89277d
11 changes: 8 additions & 3 deletions Doc/library/os.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3536,9 +3536,14 @@ written in Python, such as a mail server's external command delivery program.

If *mode* is :const:`P_NOWAIT`, this function returns the process id of the new
process; if *mode* is :const:`P_WAIT`, returns the process's exit code if it
exits normally, or ``-signal`` on non-VxWorks platform, where *signal* is the
signal that killed the process. On Windows, the process id will actually be the
process handle, so can be used with the :func:`waitpid` function.
exits normally, or ``-signal``, where *signal* is the signal that killed the
process. On Windows, the process id will actually be the process handle, so can
be used with the :func:`waitpid` function.

On VxWorks, if *mode* is :const:`P_NOWAIT`, this function returns the process id
of the new process; if *mode* is :const:`P_WAIT`, only returns the new process's
exit code if it exits normally. The process id will actually be the process
handle, so can be used with the :func:`waitpid` function.

@vstinner vstinner May 17, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description seems to be redundant with the previous paragraph. I don't see how it's different from the previous paragraph. And it seems obvious to that the a process is can be passed to waitpid(), I don't see the point of saying it here.

@pxinwr pxinwr May 17, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really some confusion here. The difference we want to express here is in P_WAIT mode if the process is killed by others, VxWorks doesn't return "-signal" as unix-like OS does. VxWorks just returns -1 in this case.


Comment thread
vstinner marked this conversation as resolved.
The "l" and "v" variants of the :func:`spawn\* <spawnl>` functions differ in how
command-line arguments are passed. The "l" variants are perhaps the easiest
Expand Down