Skip to content

gh-121149: improve accuracy of builtin sum() for complex inputs #121176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rhettinger merged 10 commits into from
Jul 5, 2024
Merged

gh-121149: improve accuracy of builtin sum() for complex inputs #121176

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e69b14a
gh-121149: improve accuracy of builtin sum() for complex inputs
skirpichev Jun 28, 2024
c430980
+ PEP7fy
skirpichev Jun 30, 2024
9998010
Fix _Py_DECREF_SPECIALIZED in PyComplex* branch
skirpichev Jul 2, 2024
4c6f4f4
+1
skirpichev Jul 2, 2024
c0a0c31
Merge branch 'master' into sum-complex-121149
skirpichev Jul 3, 2024
2698be6
address review: better naming, some cleanup
skirpichev Jul 3, 2024
5242bd6
address review: functional style
skirpichev Jul 3, 2024
1cec4ab
+ test invariant
skirpichev Jul 3, 2024
606b524
Update Lib/test/test_builtin.py
rhettinger Jul 3, 2024
35cf4d8
Update Doc/library/functions.rst
rhettinger Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
+ test invariant
  • Loading branch information
@skirpichev
skirpichev committed Jul 3, 2024
commit 1cec4abd4c93b700b2f71d3bf3d433d8bd99ca22
5 changes: 5 additions & 0 deletions Lib/test/test_builtin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1768,6 +1768,11 @@ def __getitem__(self, index):
sum(([x] for x in range(10)), empty)
self.assertEqual(empty, [])

xs = [complex(random.random() - .5, random.random() - .5)
for _ in range(10000)]
self.assertEqual(sum(xs), complex(sum(_.real for _ in xs),
Comment thread
rhettinger marked this conversation as resolved.
Outdated
sum(_.imag for _ in xs)))
Comment thread
rhettinger marked this conversation as resolved.
Outdated

@requires_IEEE_754
@unittest.skipIf(HAVE_DOUBLE_ROUNDING,
"sum accuracy not guaranteed on machines with double rounding")
Expand Down