Skip to content

[3.12] gh-120671: Fix PY_CHECK_CC_WARNING() in configure.ac (GH-120822) #120986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 1 commit into from
Jun 25, 2024
Merged

[3.12] gh-120671: Fix PY_CHECK_CC_WARNING() in configure.ac (GH-120822) #120986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
gh-120671: Fix PY_CHECK_CC_WARNING() in configure.ac (GH-120822) 
Add missing space in AS_VAR_APPEND() on CFLAGS.
(cherry picked from commit 2106c9b)

Co-authored-by: Michael Allwright <allsey87@gmail.com>
  • Loading branch information
@allsey87 @miss-islington
allsey87 authored and miss-islington committed Jun 25, 2024
commit 42bec11d22555790cb31aa7fa622be8481739451
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Build/2024-06-21-09-24-03.gh-issue-120671.Z8sBQB.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix failing configure tests due to a missing space when appending to CFLAGS.
16 changes: 8 additions & 8 deletions configure
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2371,7 +2371,7 @@ AC_DEFUN([PY_CHECK_CC_WARNING], [
AS_VAR_PUSHDEF([py_var], [ac_cv_$1_]m4_normalize($2)[_warning])
AC_CACHE_CHECK([m4_ifblank([$3], [if we can $1 $CC $2 warning], [$3])], [py_var], [
AS_VAR_COPY([py_cflags], [CFLAGS])
AS_VAR_APPEND([CFLAGS], ["-W$2 -Werror"])
AS_VAR_APPEND([CFLAGS], [" -W$2 -Werror"])
AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[]], [[]])],
[AS_VAR_SET([py_var], [yes])],
[AS_VAR_SET([py_var], [no])])
Expand Down