Skip to content

gh-118507: Amend news entry - #120817

Merged
zooba merged 2 commits into
python:mainfrom
nineteendo:amend-news-entry
Jul 4, 2024
Merged

zooba merged 2 commits into
python:mainfrom
nineteendo:amend-news-entry

Conversation

@nineteendo

@nineteendo nineteendo commented Jun 21, 2024 •

Copy link
Copy Markdown
Contributor

Adds extra information only present in the backport to the 3.12 branch.

@bedevere-app bedevere-app Bot added the docs Documentation in the Doc dir label Jun 21, 2024
@nineteendo

Copy link
Copy Markdown
Contributor Author

cc @zooba

@zooba

zooba commented Jul 4, 2024

Copy link
Copy Markdown
Member

I'm unclear. This PR is against main, which means we'll be announcing that pipes were fixed in 3.14 - why do you say it is only in 3.12?

Which branches need this change?

@nineteendo

Copy link
Copy Markdown
Contributor Author

That's correct, pipes were fixed in 3.13 and 3.14, but only the speedup to os.path.isjunction() and os.path.lexists() was mentioned. I only mentioned this fix in the backport to 3.12.

@zooba zooba added the needs backport to 3.13 only security fixes label Jul 4, 2024
@zooba
zooba merged commit db17291 into python:main Jul 4, 2024
@miss-islington-app

Copy link
Copy Markdown

Thanks @nineteendo for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

Copy link
Copy Markdown

Sorry, @nineteendo and @zooba, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker db1729143de0775c99e0453cb0fc01a799f289a0 3.13

@nineteendo
nineteendo deleted the amend-news-entry branch July 4, 2024 14:58
@bedevere-app

bedevere-app Bot commented Jul 4, 2024

Copy link
Copy Markdown

GH-121365 is a backport of this pull request to the 3.13 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants