Skip to content

gh-117657: Enable TSAN check on macOS with free-threads build #120502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aisk wants to merge 7 commits into from
Closed

gh-117657: Enable TSAN check on macOS with free-threads build #120502

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
eb3135b
Enable TSAN check on macOS with free-threads build
aisk Jun 14, 2024
b86782e
fix tsan
aisk Jun 14, 2024
0fcc952
skip install dependencies on macos in tsan
aisk Jun 14, 2024
3136d75
using different binary name for tsan test on macos
aisk Jun 14, 2024
3cf67e8
fix typo
aisk Jun 14, 2024
9301018
skip some tests
aisk Jun 18, 2024
8bc1a79
Merge branch 'main' into tsan-macos
aisk Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Enable TSAN check on macOS with free-threads build
  • Loading branch information
@aisk
aisk committed Jun 14, 2024
commit eb3135b9b6b242ca33427dbf4fb2c9aa75031705
1 change: 1 addition & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,6 +500,7 @@ jobs:
options: ./configure --config-cache --disable-gil --with-thread-sanitizer --with-pydebug
suppressions_path: Tools/tsan/suppressions_free_threading.txt
tsan_logs_artifact_name: tsan-logs-free-threading
os-matrix: '["ubuntu-22.04", "macos-14"]'

@hugovk hugovk Jun 18, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid queuing up too many jobs for the limited number of macOS builders, we'd want to use macos-14 for forks, but Cirrus for upstream builds.

See elsewhere in this file for examples, also needs changes in the reusable workflow.


# CIFuzz job based on https://google.github.io/oss-fuzz/getting-started/continuous-integration/
cifuzz:
Expand Down