Skip to content

gh-120417: Add #noqa to used imports in the stdlib #120421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 9 commits into from
Jun 13, 2024
Merged

gh-120417: Add #noqa to used imports in the stdlib #120421

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8347c30
gh-120417: Add #noqa to used imports in the stdlib
vstinner Jun 12, 2024
19ceb4d
Add more # noqa for more fun
vstinner Jun 12, 2024
9b97f47
One more #noqa batch
vstinner Jun 12, 2024
2189665
Fix test_symtable
vstinner Jun 12, 2024
e31a9e2
Revert
vstinner Jun 12, 2024
7d93caa
Merge branch 'main' into import_noqa
vstinner Jun 12, 2024
13efcc9
Add comments
vstinner Jun 12, 2024
648969c
Update Lib/pydoc.py
serhiy-storchaka Jun 13, 2024
0506006
Use "# noqa: F401"
vstinner Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add comments
  • Loading branch information
@vstinner
vstinner committed Jun 12, 2024
commit 13efcc91cadd3519fb93d3d93968899e71e39cf0
1 change: 1 addition & 0 deletions Lib/collections/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
_collections_abc.MutableSequence.register(deque)

try:
# Expose _deque_iterator to support pickling deque iterators
from _collections import _deque_iterator # noqa
except ImportError:
pass
Comment on lines 48 to 52

@AlexWaygood AlexWaygood Jun 12, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_collections passes for me if I remove this import. Does it need to stay? It was added in 52f96d3

@vstinner vstinner Jun 12, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erlend-aasland @kumaraditya303: Do you know/recall why this symbol is exposed?

@AlexWaygood AlexWaygood Jun 12, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, test_deque fails if the import is removed. I expected deque to be tested as part of test_collections, but apparently it has its own test file. Could you add a comment that it is (apparently) required to expose it in the collections module in order for deque iterators to be pickled?

======================================================================
ERROR: test_iterator_pickle (test.test_deque.TestBasic.test_iterator_pickle)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/alexw/dev/cpython/Lib/test/test_deque.py", line 640, in test_iterator_pickle
    dump = pickle.dumps((itorg, orig), proto)
_pickle.PicklingError: Can't pickle <class 'collections._deque_iterator'>: attribute lookup _deque_iterator on collections failed

----------------------------------------------------------------------

@vstinner vstinner Jun 12, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I added a comment.

Expand Down
4 changes: 3 additions & 1 deletion Lib/pydoc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,9 @@ class or function within a module or module in a package. If the

from _pyrepl.pager import (get_pager, pipe_pager,
plain_pager, tempfile_pager, tty_pager,
Comment thread
serhiy-storchaka marked this conversation as resolved.
Outdated
plain) # noqa

# Expose plain() as pydoc.plain()
from _pyrepl.pager import plain # noqa


# --------------------------------------------------------- old names
Expand Down