Skip to content

gh-119664: use conditional removal notice for codeobject.co_lnotab - #120263

Closed
picnixz wants to merge 1 commit into
python:mainfrom
picnixz:harmonize-co-lnotab-docs
Closed

picnixz wants to merge 1 commit into
python:mainfrom
picnixz:harmonize-co-lnotab-docs

Conversation

@picnixz

@picnixz picnixz commented Jun 8, 2024 •

Copy link
Copy Markdown
Member

This is an alternative to #119665 where the removal notice is written in a conditional form.

  • For 3.10: replaced the explicit 3.12 by "future version"
  • For 3.11: nothing was mentioned.
  • For 3.12: used the original 3.13 formulation for the "Deprecated" section. Moved the item under the "Pending removal in 3.14" into the "Pending removal" section. Used the same formulation as in 3.13 as well. Replace the explicit mention of 3.14 by "future version".
  • For 3.13: merged the verbose deprecation notice in the "Deprecated" section with the deprecation notice in the "Pending removal" section. That way, we know that 3.13 is only reminding us that something will be removed in the future, but this is not something that was deprecated in 3.13. There is no need for a "future version" or a "3.14" mention since it is under the "Pending removal in a future version" section.

cc @iritkatriel


📚 Documentation preview 📚: https://cpython-previews--120263.org.readthedocs.build/

@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting review labels Jun 8, 2024
@picnixz

picnixz commented Aug 27, 2024

Copy link
Copy Markdown
Member Author

I'm closing this one. I don't think it's worth changing the wording.

@picnixz picnixz closed this Aug 27, 2024
@picnixz
picnixz deleted the harmonize-co-lnotab-docs branch August 27, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant