Skip to content

gh-117657: Fix race involving immortalizing objects #119927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colesbury merged 4 commits into from
Jun 3, 2024
Merged

gh-117657: Fix race involving immortalizing objects #119927

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
45afd9d
gh-117657: Fix race involving immortalizing objects
colesbury Jun 1, 2024
73cff1f
Merge branch 'main' into gh-117657-immortalize
colesbury Jun 2, 2024
be3ec68
Fix formatting
colesbury Jun 2, 2024
170299b
Merge branch 'main' into gh-117657-immortalize
colesbury Jun 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix formatting
  • Loading branch information
@colesbury
colesbury authored Jun 2, 2024
commit be3ec68f8ec3a6c1ab817528835175c5d4c3cf5f
3 changes: 1 addition & 2 deletions Python/pystate.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1583,8 +1583,7 @@ new_threadstate(PyInterpreterState *interp, int whence)
}
else {
#ifdef Py_GIL_DISABLED
if (_Py_atomic_load_int(&interp->gc.immortalize) == 0)
{
if (_Py_atomic_load_int(&interp->gc.immortalize) == 0) {
// Immortalize objects marked as using deferred reference counting
// the first time a non-main thread is created.
_PyGC_ImmortalizeDeferredObjects(interp);
Expand Down