Repository navigation
GH-119476: Split _CHECK_FUNCTION_VERSION out of _CHECK_FUNCTION_EXACT_ARGS - #119510
Merged
Merged
Conversation
brandtbucher
added
performance
brandtbucher
requested review from
Fidget-Spinner,
gvanrossum and
markshannon
as code owners
May 24, 2024 15:35
Fidget-Spinner
approved these changes
May 25, 2024
2 tasks done
brandtbucher
changed the title
_CHECK_FUNCTION_VERSION out of _CHECK_FUNCTION_EXACT_ARGS_CHECK_FUNCTION_VERSION out of _CHECK_FUNCTION_EXACT_ARGS
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should allow us to optimize away the function version check in many more places, once we start doing that.
CC @saulshanabrook