Skip to content

gh-119342: Fix a potential denial of service in plistlib #119343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 7 commits into from
Dec 1, 2025
Merged

gh-119342: Fix a potential denial of service in plistlib #119343

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6969658
gh-119342: Fix OOM vulnerability in plistlib
serhiy-storchaka May 21, 2024
efcb8c5
Apply suggestions from code review
serhiy-storchaka May 22, 2024
412032b
Use a named constant.
serhiy-storchaka May 22, 2024
64fc738
Update 2024-05-21-22-11-31.gh-issue-119342.BTFj4Z.rst
serhiy-storchaka Nov 18, 2025
ae1d2bc
Merge branch 'main' into plistlib-oom
serhiy-storchaka Nov 18, 2025
9e18b74
Merge branch 'main' into plistlib-oom
serhiy-storchaka Dec 1, 2025
82093fb
Address review comments.
serhiy-storchaka Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
  • Loading branch information
@serhiy-storchaka @picnixz
serhiy-storchaka and picnixz authored May 22, 2024
commit efcb8c5cf71a6604e4b5378feaa3c70f65abfedc
7 changes: 0 additions & 7 deletions Lib/plistlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,11 +509,6 @@ def _get_size(self, tokenL):
return tokenL

def _read(self, size):
if 0:
data = self._fp.read(size)
if len(data) != size:
raise InvalidFileException
return data
cursize = min(size, 1 << 20)
Comment thread
serhiy-storchaka marked this conversation as resolved.
Outdated
data = self._fp.read(cursize)
while True:
Expand All @@ -527,8 +522,6 @@ def _read(self, size):

def _read_ints(self, n, size):
data = self._read(size * n)
#print('XXX', n, size)
#assert n < 100
if size in _BINARY_FORMAT:
return struct.unpack(f'>{n}{_BINARY_FORMAT[size]}', data)
else:
Expand Down