Skip to content

gh-119011: Return an empty tuple on type_get_type_params as special case for PyType_Type #119313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mdkcore0 wants to merge 2 commits into from
Closed

gh-119011: Return an empty tuple on type_get_type_params as special case for PyType_Type #119313

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a493713
gh-119011: Return an empty tuple on type_get_type_params as special c…
mdkcore0 May 20, 2024
1a8c6d2
Update Misc/NEWS.d/next/Core and Builtins/2024-05-21-11-51-54.gh-issu…
carljm May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
gh-119011: Return an empty tuple on type_get_type_params as special c… 
…ase for PyType_Type
  • Loading branch information
@mdkcore0
mdkcore0 committed May 21, 2024
commit a49371355df088f6cea6b38ac681a21ac17153e2
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Core and Builtins/2024-05-21-11-51-54.gh-issue-119011.Ja5dwc.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
This fixes an issue with ``functools.update_wrapper`` where it was not
returning a tuple for ``__type_params__`` as expected.
Comment thread
carljm marked this conversation as resolved.
Outdated
2 changes: 1 addition & 1 deletion Objects/typeobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1743,7 +1743,7 @@ static PyObject *
type_get_type_params(PyTypeObject *type, void *context)
{
PyObject *params;
if (PyDict_GetItemRef(lookup_tp_dict(type), &_Py_ID(__type_params__), &params) == 0) {
if (type == &PyType_Type || PyDict_GetItemRef(lookup_tp_dict(type), &_Py_ID(__type_params__), &params) == 0) {
return PyTuple_New(0);
}
return params;
Expand Down