Skip to content

bpo-36004: Add date.fromisocalendar #11888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 14 commits into from
Apr 29, 2019
Merged

bpo-36004: Add date.fromisocalendar #11888

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
6d323ad
Add date.fromisocalendar and tests
pganssle Feb 15, 2019
fbab728
Add early year check to fromisocalendar
pganssle Feb 17, 2019
925de2f
Covert OverflowError into ValueError
pganssle Feb 17, 2019
3ecf02e
Add bounds checking for ISO long vs. short weeks
pganssle Feb 17, 2019
e645cd0
Add more comments with test cases
pganssle Feb 17, 2019
86edee5
Switch to new method of detecting ISO long years
pganssle Feb 17, 2019
74fb523
Fix missing argument in PyErr_Format
pganssle Feb 17, 2019
46c6458
Add test for TypeError handling
pganssle Feb 17, 2019
28c7fb2
Add documentation for date(time).fromisocalendar
pganssle Feb 17, 2019
99e75d7
Add NEWS entry
pganssle Feb 17, 2019
c269a5c
Add What's New entry for fromisocalendar
pganssle Mar 17, 2019
c8444b7
Use MINYEAR and MAXYEAR in bounds checks
pganssle Apr 29, 2019
958ffff
Add tests for MINYEAR and MAXYEAR
pganssle Apr 29, 2019
3307865
Use generated test cases instead of manual list
pganssle Apr 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add test for TypeError handling
  • Loading branch information
@pganssle
pganssle committed Apr 29, 2019
commit 46c6458bc0fab491b556b8c8b611b7c1203ff0dc
18 changes: 18 additions & 0 deletions Lib/test/datetimetester.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1845,6 +1845,24 @@ def test_fromisocalendar_value_errors(self):
with self.assertRaises(ValueError):
self.theclass.fromisocalendar(*isocal)

def test_fromisocalendar_type_errors(self):
isocals = [
("2019", 1, 1),
(2019, "1", 1),
(2019, 1, "1"),
(None, 1, 1),
(2019, None, 1),
(2019, 1, None),
(2019.0, 1, 1),

@pganssle pganssle Feb 17, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing I'll note is that this is consistent with datetime.date itself not accepting floats. I'm not sure how much I agree with that, I just wanted to put it in the tests to ensure consistency between the C and Python versions.

(2019, 1.0, 1),
(2019, 1, 1.0),
]

@vstinner vstinner Apr 28, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to use 3 loops to test all combinations, rather than generate these combinations manualy?

@pganssle pganssle Apr 29, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I've converted it over. I think it's a little harder to understand what's going on in the version where the test cases are generated (compared to manual), but using a loop also has its advantages.


for isocal in isocals:
with self.subTest(isocal=isocal):
with self.assertRaises(TypeError):
self.theclass.fromisocalendar(*isocal)


#############################################################################
# datetime tests
Expand Down