Skip to content

gh-111495: Add tests for PyTuple C API #118757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 24 commits into from
Aug 26, 2024
Merged

gh-111495: Add tests for PyTuple C API #118757

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
0e590c4
gh-111495: Add tests for PyTuple C API
rawwar Nov 1, 2023
ddf0af7
+1
skirpichev May 8, 2024
571da31
Update Lib/test/test_capi/test_tuple.py
skirpichev May 9, 2024
69d9ead
address review: more tests
skirpichev May 9, 2024
3260ef4
address review: simplify tuple_pack()
skirpichev May 9, 2024
b5b4664
address review: strict checks in tuple_set_item/setitem
skirpichev May 9, 2024
1d53b0f
address review: redo resize() tests
skirpichev May 10, 2024
3248144
Merge branch 'master' into capi-tuple-tests
skirpichev Jun 17, 2024
8451a4d
address review:
skirpichev Jun 17, 2024
b2d0eac
address review: check error for PyTuple_SetItem()
skirpichev Jun 18, 2024
a977efa
address review: fix reference leak and add tests for non-immortal obj…
skirpichev Jun 18, 2024
95d1544
Add missing unittest.main() calls
skirpichev Jun 18, 2024
14b3594
address review: add tests with NULL for setitem/set_item
skirpichev Jun 18, 2024
f9554bc
address review: fix refleak
skirpichev Jun 18, 2024
e79616f
address review: rename tuple_resize
skirpichev Jun 18, 2024
26fc5a2
address review: a helper to test if item is NULL
skirpichev Jun 18, 2024
5047d6d
address review: check no refleaks if tuple shrinks
skirpichev Jun 18, 2024
a2ea4c4
address review: test added elements on resize
skirpichev Jun 18, 2024
72aa1ed
address review: test new elements
skirpichev Jun 18, 2024
f10160c
Merge branch 'main' into capi-tuple-tests
serhiy-storchaka Aug 8, 2024
8a6d636
Merge branch 'main' into capi-tuple-tests
skirpichev Aug 9, 2024
266de84
Polish and fix some errors.
serhiy-storchaka Aug 9, 2024
190e88a
Update Modules/_testcapi/tuple.c
serhiy-storchaka Aug 9, 2024
d25eae8
Address Victor's comments.
serhiy-storchaka Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
address review: fix refleak
  • Loading branch information
@skirpichev
skirpichev committed Jun 18, 2024
commit f9554bc8d9807eaa3abdc47c4561bb0de79e13e4
1 change: 1 addition & 0 deletions Modules/_testlimitedcapi/tuple.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ tuple_setitem(PyObject *Py_UNUSED(module), PyObject *args)
for (Py_ssize_t n = 0; n < size; n++) {
if (PyTuple_SetItem(newtuple, n,
Py_XNewRef(PyTuple_GetItem(obj, n))) == -1) {
Py_XDECREF(newtuple);
return NULL;
Comment thread
skirpichev marked this conversation as resolved.
}
}
Expand Down