Skip to content

gh-118613: Fix error handling of _PyEval_GetFrameLocals in ceval.c #118614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sobolevn merged 3 commits into from
May 6, 2024
Merged

gh-118613: Fix error handling of _PyEval_GetFrameLocals in ceval.c #118614

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab44c4a
gh-118613: Fix error handling of `_PyEval_GetFrameLocals` in `ceval.c`
sobolevn May 5, 2024
652289d
PyDict_Update handling
sobolevn May 5, 2024
d1e1c5d
Address review
sobolevn May 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Address review
  • Loading branch information
@sobolevn
sobolevn committed May 5, 2024
commit d1e1c5d41d6fe5e4b251a4e0f539657361920d22
5 changes: 2 additions & 3 deletions Python/ceval.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2507,11 +2507,10 @@ _PyEval_GetFrameLocals(void)
}
Py_DECREF(locals);
return ret;
} else if (PyMapping_Check(locals)) {
return locals;
}

return NULL;
assert(PyMapping_Check(locals));
return locals;
}

PyObject *
Expand Down