Skip to content

gh-118527: Use _Py_ID(__main__) for main module name #118528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colesbury merged 1 commit into from
May 3, 2024
Merged

gh-118527: Use _Py_ID(__main__) for main module name #118528

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
gh-118527: Use constant for __main__ name 
Most module names are interned and immortalized, but the `__main__`
module was not. This partially addresses a scaling bottleneck in the
free-threaded when creating closure concurrently in the main module.
  • Loading branch information
@colesbury
colesbury committed May 3, 2024
commit 1513a2bea07e93768165deb662cd2bae9f098b1e
2 changes: 1 addition & 1 deletion Python/pylifecycle.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2348,7 +2348,7 @@ static PyStatus
add_main_module(PyInterpreterState *interp)
{
PyObject *m, *d, *ann_dict;
m = PyImport_AddModule("__main__");
m = PyImport_AddModuleObject(&_Py_ID(__main__));
if (m == NULL)
return _PyStatus_ERR("can't create __main__ module");

Expand Down