Skip to content

gh-118362: Fix thread safety around lookups from the type cache in the face of concurrent mutators #118454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DinoV merged 4 commits into from
May 6, 2024
Merged

gh-118362: Fix thread safety around lookups from the type cache in the face of concurrent mutators #118454

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c688d6b
Add _PyType_Fetch and use incref before setting attribute on type
DinoV Apr 30, 2024
8074d0d
Rename _PyType_Fetch -> _PyType_LookupRef
DinoV May 1, 2024
9367312
ctypes should use base implemetantation for setting attribute
DinoV May 1, 2024
179dcd9
Handle failure to create dict, fix formatting, remove extra pyerr_occ…
DinoV May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ctypes should use base implemetantation for setting attribute
  • Loading branch information
@DinoV
DinoV committed May 1, 2024
commit 9367312a0306960a33a5a49a4d2844294d903e93
2 changes: 1 addition & 1 deletion Modules/_ctypes/_ctypes.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1096,7 +1096,7 @@ static int
UnionType_setattro(PyObject *self, PyObject *key, PyObject *value)
{
/* XXX Should we disallow deleting _fields_? */
if (-1 == PyObject_GenericSetAttr(self, key, value))
if (-1 == PyType_Type.tp_setattro(self, key, value))
return -1;

if (PyUnicode_Check(key) &&
Expand Down