Skip to content

gh-88494: Reduce CLOCK_RES to 1 ms in tests #118395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vstinner wants to merge 2 commits into from
Closed

gh-88494: Reduce CLOCK_RES to 1 ms in tests #118395

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be949bb
gh-88494: Reduce CLOCK_RES to 1 ms in tests
vstinner Apr 29, 2024
eb4e7d3
Fix test_asyncio.test_windows_events
vstinner Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
gh-88494: Reduce CLOCK_RES to 1 ms in tests 
On Windows, time.monotonic() now calls QueryPerformanceCounter()
which has a resolution of 100 ns. Reduce CLOCK_RES from 50 or 100 ms
to 1 ms.
  • Loading branch information
@vstinner
vstinner committed Apr 29, 2024
commit be949bbfa64912e2fb80132335c6654594a6032b
4 changes: 2 additions & 2 deletions Lib/test/_test_multiprocessing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,9 @@
raise unittest.SkipTest("libasan has a pthread_create() dead lock related to thread+fork")


# gh-110666: Tolerate a difference of 100 ms when comparing timings
# gh-110666: Tolerate a difference of 1 ms when comparing timings
# (clock resolution)
CLOCK_RES = 0.100
CLOCK_RES = 0.001


def latin(s):
Expand Down
6 changes: 2 additions & 4 deletions Lib/test/test_asyncio/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,8 @@
from test.support import threading_helper


# Use the maximum known clock resolution (gh-75191, gh-110088): Windows
# GetTickCount64() has a resolution of 15.6 ms. Use 50 ms to tolerate rounding
# issues.
CLOCK_RES = 0.050
# Tolerate 1 ms difference when comparing timings.
CLOCK_RES = 0.001


def data_file(*filename):
Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_capi/test_time.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
SEC_TO_NS = 10 ** 9
DAY_TO_SEC = (24 * 60 * 60)
# Worst clock resolution: maximum delta between two clock reads.
CLOCK_RES = 0.050
CLOCK_RES = 0.001


class CAPITest(unittest.TestCase):
Expand Down