Skip to content

gh-76785: Consolidate Some Interpreter-related Testing Helpers #117485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericsnowcurrently merged 4 commits into from
Apr 2, 2024
Merged

gh-76785: Consolidate Some Interpreter-related Testing Helpers #117485

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a489f83
Move some test utils to _xxsubinterpreters module.
ericsnowcurrently Apr 2, 2024
9adf2d0
Update remaining sites to the new helper API.
ericsnowcurrently Apr 2, 2024
5b34771
Skip InterpreterConfigTests on WASI.
ericsnowcurrently Apr 2, 2024
b7b5b15
Fix a typo.
ericsnowcurrently Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Skip InterpreterConfigTests on WASI.
  • Loading branch information
@ericsnowcurrently
ericsnowcurrently committed Apr 2, 2024
commit 5b34771def5dbc54534fb4a0617450b10302ffe6
3 changes: 1 addition & 2 deletions Lib/test/test_capi/test_misc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2204,6 +2204,7 @@ def test_module_state_shared_in_global(self):
self.assertEqual(main_attr_id, subinterp_attr_id)


@requires_subinterpreters
class InterpreterConfigTests(unittest.TestCase):

supported = {
Expand Down Expand Up @@ -2353,7 +2354,6 @@ def test_update_from_dict(self):
with self.assertRaises(ValueError):
_interpreters.new_config(gil=value)

@requires_subinterpreters
def test_interp_init(self):
questionable = [
# strange
Expand Down Expand Up @@ -2412,7 +2412,6 @@ def check(config):
with self.subTest(f'valid: {config}'):
check(config)

@requires_subinterpreters
def test_get_config(self):
@contextlib.contextmanager
def new_interp(config):
Expand Down