Skip to content

gh-117483: Accept "Broken pipe" as valid error message in test_wrong_cert_tls13 #117484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 1 commit into from
Apr 3, 2024
Merged

gh-117483: Accept "Broken pipe" as valid error message in test_wrong_cert_tls13 #117484

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
gh-117483: Accept "Broken pipe" as valid error message in `test_wrong… 
…_cert_tls13`

On macOS, the closed connection can lead to a "Broken pipe" error instead of
a "Connection reset by peer" error.
  • Loading branch information
@colesbury
colesbury committed Apr 2, 2024
commit db1b20856b3837a844ffd554d053ff8fb67eaad5
4 changes: 3 additions & 1 deletion Lib/test/test_ssl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3169,7 +3169,9 @@ def test_wrong_cert_tls13(self):
s.connect((HOST, server.port))
with self.assertRaisesRegex(
OSError,
'alert unknown ca|EOF occurred|TLSV1_ALERT_UNKNOWN_CA|closed by the remote host|Connection reset by peer'
'alert unknown ca|EOF occurred|TLSV1_ALERT_UNKNOWN_CA|'
'closed by the remote host|Connection reset by peer|'
'Broken pipe'
):
# TLS 1.3 perform client cert exchange after handshake
s.write(b'data')
Expand Down