Skip to content

gh-116749: Run test suite with the GIL disabled #117437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
colesbury wants to merge 24 commits into from
Closed

gh-116749: Run test suite with the GIL disabled #117437

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
2f299af
Disable GIL by default
colesbury Mar 12, 2024
3d270d2
gh-112075: Lock when inserting into shared keys
colesbury Apr 8, 2024
2e5797e
Fix return type
colesbury Apr 15, 2024
79eb85c
Make instance attributes stored in inline "dict" thread safe
DinoV Apr 2, 2024
68fa243
Insert into dict on store if dict is materialized and other feedback
DinoV Apr 4, 2024
6d37f80
_PyObject_TryStoreInstanceAttribute -> _PyObject_StoreInstanceAttribute
DinoV Apr 15, 2024
91e82d6
Cleanup _PyObject_SetManagedDict, use cst for inline valid flag, fix …
DinoV Apr 16, 2024
319f632
Refactor del/set into set_or_del_lock_held, and avoid locking on newl…
DinoV Apr 17, 2024
2f6ca58
tracing thread safety
DinoV Mar 12, 2024
fe19d59
Lock on allocation, use version as sync point
DinoV Mar 25, 2024
210b802
Lock in non-debug builds
DinoV Mar 28, 2024
597f40d
Move CHECK_EVAL_BREAKER in ENTER_EXECUTOR
DinoV Mar 29, 2024
8393bfe
Don't potentially leak executor
DinoV Apr 2, 2024
65ff505
Just use _Py_atomic_exchange_ptr instead of FT macro
DinoV Apr 4, 2024
6e19601
Use FT_ATOMIC_LOAD_UINTPTR_ACQUIRE for INSTRUMENTED_RESUME too
DinoV Apr 18, 2024
8860a7f
Handle dict replacement case better
DinoV Apr 19, 2024
4b85255
Decref materialized dict on fail to set
DinoV Apr 19, 2024
30a4133
gh-117783: Immortalize objects that use deferred reference counting
colesbury Apr 12, 2024
0cab82c
Fix set_immortalize_deferred
colesbury Apr 19, 2024
c716f32
Merge branch 'disable-gil-default' into nogil-integration
colesbury Apr 19, 2024
eb8ebe4
Merge branch 'nogil_dict_pydictvalues' into nogil-integration
colesbury Apr 19, 2024
74eec36
Merge branch 'nogil_settrace' into nogil-integration
colesbury Apr 19, 2024
a825875
Merge branch 'gh-112075-lock-split-keys' into nogil-integration
colesbury Apr 19, 2024
539595a
Merge branch 'gh-117783-immortalize' into nogil-integration
colesbury Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Lock in non-debug builds
  • Loading branch information
@DinoV
DinoV committed Apr 19, 2024
commit 210b8023c0b489961bf8f12751fc8d44cd982b21
11 changes: 9 additions & 2 deletions Python/instrumentation.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,15 @@
}
#define ASSERT_WORLD_STOPPED() assert(_PyInterpreterState_GET()->stoptheworld.world_stopped);

#else

#define ASSERT_WORLD_STOPPED_OR_LOCKED(obj)
#define ASSERT_WORLD_STOPPED()

#endif

#ifdef Py_GIL_DISABLED

#define LOCK_CODE(code) \
assert(!_PyInterpreterState_GET()->stoptheworld.world_stopped); \
Py_BEGIN_CRITICAL_SECTION(code)
Expand All @@ -37,8 +46,6 @@

#else

#define ASSERT_WORLD_STOPPED_OR_LOCKED(obj)
#define ASSERT_WORLD_STOPPED()
#define LOCK_CODE(code)
#define UNLOCK_CODE()

Expand Down