Skip to content

gh-116622: Test updates for Android #117299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erlend-aasland merged 5 commits into from
Apr 5, 2024
Merged

gh-116622: Test updates for Android #117299

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6c625e6
Re-enable test_fcntl_64_bit on Linux aarch64, but disable it on all A…
mhsmith Mar 20, 2024
c8914cf
Use support.setswitchinterval in all relevant tests
mhsmith Mar 20, 2024
384f7e1
Skip test_fma_zero_result on Android x86_64
mhsmith Mar 25, 2024
236e9d0
Accept EACCES when calling os.get_terminal_size on Android
mhsmith Mar 25, 2024
69ac1f6
Remove unnecessary parentheses
mhsmith Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Accept EACCES when calling os.get_terminal_size on Android
  • Loading branch information
@mhsmith
mhsmith committed Mar 27, 2024
commit 236e9d03d6f8b35d42c4672ae384f0db22c43d2e
7 changes: 6 additions & 1 deletion Lib/test/test_os.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3931,7 +3931,12 @@ def test_does_not_crash(self):
try:
size = os.get_terminal_size()
except OSError as e:
if sys.platform == "win32" or e.errno in (errno.EINVAL, errno.ENOTTY):
known_errnos = [errno.EINVAL, errno.ENOTTY]
if sys.platform == "android":
# The Android testbed redirects the native stdout to a pipe,
# which returns a different error code.
known_errnos.append(errno.EACCES)
if (sys.platform == "win32") or (e.errno in known_errnos):

@erlend-aasland erlend-aasland Apr 5, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parentheses are not needed.

# Under win32 a generic OSError can be thrown if the
# handle cannot be retrieved
self.skipTest("failed to query terminal size")
Expand Down