Skip to content

GH-70647: Deprecate strptime day of month parsing without a year present to avoid leap-year bugs #117107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 9 commits into from
Apr 3, 2024
Merged

GH-70647: Deprecate strptime day of month parsing without a year present to avoid leap-year bugs #117107

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4b929e4
Deprecate strptime leap-year ambiguous MM-DD parsing.
gpshead Mar 20, 2024
b0eacf9
Fix the stacklevel and remove example from the warning message.
gpshead Mar 20, 2024
5851b0b
Simplify _assertNotWarns error message, removing a typo.
gpshead Mar 20, 2024
a068dac
add a unittest for _assertNotWarns.
gpshead Mar 20, 2024
333ba57
Document the behavior deprecation.
gpshead Mar 29, 2024
b12e7e5
minor doc cleanup.
gpshead Apr 1, 2024
d4c994e
adjust example code comments.
gpshead Apr 1, 2024
92e30b8
Fix doctest
encukou Apr 2, 2024
f1bd314
Use skip_file_prefixes for the warning
encukou Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add a unittest for _assertNotWarns.
  • Loading branch information
@gpshead
gpshead committed Mar 20, 2024
commit a068dac1763e4aa832f0dbe2944c2185bd3822ff
10 changes: 10 additions & 0 deletions Lib/test/test_unittest/test_assertions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,16 @@ def testAssertWarns(self):
'^UserWarning not triggered$',
'^UserWarning not triggered : oops$'])

def test_assertNotWarns(self):
def warn_future():
warnings.warn('xyz', FutureWarning, stacklevel=2)
self.assertMessagesCM('_assertNotWarns', (FutureWarning,),
warn_future,
['^FutureWarning triggered$',
'^oops$',
'^FutureWarning triggered$',
'^FutureWarning triggered : oops$'])

def testAssertWarnsRegex(self):
# test error not raised
self.assertMessagesCM('assertWarnsRegex', (UserWarning, 'unused regex'),
Expand Down
2 changes: 1 addition & 1 deletion Lib/unittest/case.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ def __exit__(self, exc_type, exc_value, tb):
for m in self.warnings:
w = m.message
if isinstance(w, self.expected):
self._raiseFailure(f"{exc_name} triggered: {w}")
self._raiseFailure(f"{exc_name} triggered")


class _OrderedChainMap(collections.ChainMap):
Expand Down