Skip to content

gh-112536: Add more TSAN tests #116896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pitrou merged 6 commits into from
Mar 16, 2024
Merged

gh-112536: Add more TSAN tests #116896

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5c810cb
gh-112536: Add more TSAN tests
corona10 Mar 16, 2024
fa2ad85
Reduce test
corona10 Mar 16, 2024
427956b
Reduce more tests
corona10 Mar 16, 2024
f981887
Exclude tests that network resources is needed
corona10 Mar 16, 2024
c624f64
Address code reivew
corona10 Mar 16, 2024
45be110
Merge branch 'main' into gh-112536-more-tests
pitrou Mar 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Reduce test
  • Loading branch information
@corona10
corona10 committed Mar 16, 2024
commit fa2ad85d318c23fe2956d2729d1790a29d54c311
6 changes: 1 addition & 5 deletions Lib/test/libregrtest/tsan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,9 @@
# chosen because they use threads and run in a reasonable amount of time.

TSAN_TESTS = [
'test_asyncio',
'test_capi',
'test_code',
'test_compileall',
Comment thread
corona10 marked this conversation as resolved.
Outdated
'test_concurrent_futures',
'test_enum',
'test_functools',
'test_fork1',
Comment thread
corona10 marked this conversation as resolved.
Outdated
Expand All @@ -15,8 +13,6 @@
'test_importlib',
'test_io',
'test_logging',
'test_multiprocessing_forkserver',
'test_multiprocessing_spawn',
'test_pickle',
Comment thread
corona10 marked this conversation as resolved.
Outdated
'test_queue',

@corona10 corona10 Mar 16, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cpython/Lib/test/test_queue.py

Line 165 in 86bc40d

def queue_join_test(self, q):

'test_smtpnet',
Expand All @@ -28,7 +24,7 @@
'test_threading',
'test_threading_local',
'test_threadsignals',
'test_urlib2net',
'test_urllib2net',
'test_weakref',

@corona10 corona10 Mar 16, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cpython/Lib/test/test_weakref.py

Lines 1837 to 1866 in 86bc40d

@threading_helper.requires_working_threading()
def test_threaded_weak_valued_setdefault(self):
d = weakref.WeakValueDictionary()
with collect_in_thread():
for i in range(100000):
x = d.setdefault(10, RefCycle())
self.assertIsNot(x, None) # we never put None in there!
del x
@threading_helper.requires_working_threading()
def test_threaded_weak_valued_pop(self):
d = weakref.WeakValueDictionary()
with collect_in_thread():
for i in range(100000):
d[10] = RefCycle()
x = d.pop(10, 10)
self.assertIsNot(x, None) # we never put None in there!
@threading_helper.requires_working_threading()
def test_threaded_weak_valued_consistency(self):
# Issue #28427: old keys should not remove new values from
# WeakValueDictionary when collecting from another thread.
d = weakref.WeakValueDictionary()
with collect_in_thread():
for i in range(200000):
o = RefCycle()
d[10] = o
# o is still alive, so the dict can't be empty
self.assertEqual(len(d), 1)
o = None # lose ref

]

Expand Down