Skip to content

gh-112536: Add TSAN builds on Github Actions #116872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pitrou merged 28 commits into from
Mar 16, 2024
Merged

gh-112536: Add TSAN builds on Github Actions #116872

Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
34cd372
gh-112536: Setting up TSAN test at Github Action
corona10 Mar 15, 2024
8f789df
Apply TSAN to the default build too
corona10 Mar 15, 2024
432c3a2
Update
corona10 Mar 15, 2024
7c04959
Use gcc 11 to resolve compiler issue
corona10 Mar 15, 2024
4d271cb
Remove test_logging from the TSAN test for the temporary
corona10 Mar 15, 2024
853ea8c
Test --with-pydebug
corona10 Mar 15, 2024
43135d4
Use Ubuntu 22.04
corona10 Mar 15, 2024
7304fca
Use --disable-ipv6 sigh..
corona10 Mar 15, 2024
37d048d
revert --with-pydebug
corona10 Mar 15, 2024
b05c9f7
Use clang
corona10 Mar 15, 2024
7e373ee
Reduce ASLR to avoid TSAN crashing
corona10 Mar 15, 2024
920d8b4
Rebirth test_logging
corona10 Mar 15, 2024
73cbf74
Add --with-pydebug
corona10 Mar 15, 2024
0ff8212
Update Tools/tsan/supressions.txt
corona10 Mar 15, 2024
c6dfb25
Add ccache
corona10 Mar 15, 2024
e2e90ee
Address code review
corona10 Mar 16, 2024
2d29262
Don't use sem_clockwait with TSAN
corona10 Mar 16, 2024
e2265a5
Skip tests from test_threading and test_concurrent_futures
corona10 Mar 16, 2024
414c0e9
Revert Tools/tsan/supressions.txt changes
corona10 Mar 16, 2024
71dc4aa
Add skip_if_tsan
corona10 Mar 16, 2024
f399bd2
nit
corona10 Mar 16, 2024
ec743ff
Use reusable workflow
corona10 Mar 16, 2024
e99087f
nit
corona10 Mar 16, 2024
8bfee01
Rename to .github/workflows/reusable-tsan.yml
corona10 Mar 16, 2024
8577792
fix
corona10 Mar 16, 2024
f9c6e56
fix
corona10 Mar 16, 2024
d9afff0
Fix
corona10 Mar 16, 2024
e88086f
nit
corona10 Mar 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add ccache
  • Loading branch information
@corona10
corona10 committed Mar 15, 2024
commit c6dfb25f25aed985e39b0491c7fc87e85acc5149
34 changes: 32 additions & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,6 +492,13 @@ jobs:
if: needs.check_source.outputs.run_tests == 'true'
steps:
- uses: actions/checkout@v4
- name: Runner image version
run: echo "IMAGE_VERSION=${ImageVersion}" >> $GITHUB_ENV
- name: Restore config.cache
uses: actions/cache@v4
with:
path: config.cache
key: ${{ github.job }}-${{ runner.os }}-${{ env.IMAGE_VERSION }}-${{ needs.check_source.outputs.config_hash }}
- name: Install Dependencies
run: |
sudo ./.github/workflows/posix-deps-apt.sh
Expand All @@ -503,8 +510,16 @@ jobs:
echo "TSAN_OPTIONS=suppressions=${GITHUB_WORKSPACE}/Tools/tsan/supressions.txt" >> $GITHUB_ENV
echo "CC=$(which clang)" >> $GITHUB_ENV
echo "CXX=$(which clang++)" >> $GITHUB_ENV
- name: Add ccache to PATH
run: |
echo "PATH=/usr/lib/ccache:$PATH" >> $GITHUB_ENV
- name: Configure ccache action
uses: hendrikmuhs/ccache-action@v1.2
with:
save: ${{ github.event_name == 'push' }}
max-size: "200M"
- name: Configure CPython
run: ./configure --with-thread-sanitizer --without-pymalloc --with-pydebug
run: ./configure --config-cache --with-thread-sanitizer --without-pymalloc --with-pydebug

@pitrou pitrou Mar 15, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can try removing --without-pymalloc. It shouldn't interfere with TSAN.

- name: Build CPython
run: make -j4
- name: Display build info
Expand All @@ -520,6 +535,13 @@ jobs:
if: needs.check_source.outputs.run_tests == 'true'
steps:
- uses: actions/checkout@v4
- name: Runner image version
run: echo "IMAGE_VERSION=${ImageVersion}" >> $GITHUB_ENV
- name: Restore config.cache
uses: actions/cache@v4
with:
path: config.cache
key: ${{ github.job }}-${{ runner.os }}-${{ env.IMAGE_VERSION }}-${{ needs.check_source.outputs.config_hash }}
- name: Install Dependencies
run: |
sudo ./.github/workflows/posix-deps-apt.sh
Expand All @@ -531,8 +553,16 @@ jobs:
echo "TSAN_OPTIONS=suppressions=${GITHUB_WORKSPACE}/Tools/tsan/supressions.txt" >> $GITHUB_ENV
echo "CC=$(which clang)" >> $GITHUB_ENV
echo "CXX=$(which clang++)" >> $GITHUB_ENV
- name: Add ccache to PATH
run: |
echo "PATH=/usr/lib/ccache:$PATH" >> $GITHUB_ENV
- name: Configure ccache action
uses: hendrikmuhs/ccache-action@v1.2
with:
save: ${{ github.event_name == 'push' }}
max-size: "200M"
- name: Configure CPython
run: ./configure --disable-gil --with-thread-sanitizer --with-pydebug
run: ./configure --config-cache --disable-gil --with-thread-sanitizer --with-pydebug
- name: Build CPython
run: make -j4
- name: Display build info
Expand Down