Skip to content

subprocess: close pipes/fds by using ExitStack #11686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpshead merged 4 commits into from
Jan 29, 2019
Merged

subprocess: close pipes/fds by using ExitStack #11686

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a294842
subprocess: close pipes/fds by using ExitStack
giampaolo Jan 27, 2019
93ac155
avoid try/finally block around CloseHandle()
giampaolo Jan 27, 2019
685cef2
fix accidental removal of CloseHandle() calls
giampaolo Jan 27, 2019
65374c6
add NEWS entry
giampaolo Jan 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix accidental removal of CloseHandle() calls
  • Loading branch information
@giampaolo
giampaolo committed Jan 27, 2019
commit 685cef2970dfdaa157bab3149c63257041f71c0c
2 changes: 2 additions & 0 deletions Lib/subprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1115,6 +1115,7 @@ def _get_handles(self, stdin, stdout, stderr):
if p2cread is None:
p2cread, _ = _winapi.CreatePipe(None, 0)
p2cread = Handle(p2cread)
_winapi.CloseHandle(_)
elif stdin == PIPE:
p2cread, p2cwrite = _winapi.CreatePipe(None, 0)
p2cread, p2cwrite = Handle(p2cread), Handle(p2cwrite)
Expand All @@ -1132,6 +1133,7 @@ def _get_handles(self, stdin, stdout, stderr):
if c2pwrite is None:
_, c2pwrite = _winapi.CreatePipe(None, 0)
c2pwrite = Handle(c2pwrite)
_winapi.CloseHandle(_)
elif stdout == PIPE:
c2pread, c2pwrite = _winapi.CreatePipe(None, 0)
c2pread, c2pwrite = Handle(c2pread), Handle(c2pwrite)
Expand Down