Skip to content

GH-116017: Put JIT code and data on the same page #116845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandtbucher merged 8 commits into from
Mar 19, 2024
Merged

GH-116017: Put JIT code and data on the same page #116845

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
84bbac4
Use one mprotect call instead of two
brandtbucher Feb 29, 2024
4f21fe2
Don't use separate pages for code and data
brandtbucher Mar 1, 2024
9217066
Fix alignment issues
brandtbucher Mar 1, 2024
41455df
Add missing alignment check
brandtbucher Mar 1, 2024
6efff81
Catch up with main
brandtbucher Mar 14, 2024
36c6c78
Clean up alignement calculation
brandtbucher Mar 14, 2024
26c31d9
Be extra paranoid
brandtbucher Mar 15, 2024
e6d8e6d
total_size
brandtbucher Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clean up alignement calculation
  • Loading branch information
@brandtbucher
brandtbucher committed Mar 14, 2024
commit 36c6c78af6149b7bfe589782a22bba7dbe89781b
2 changes: 1 addition & 1 deletion Tools/jit/_stencils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ def remove_jump(self, *, alignment: int = 1) -> None:
offset -= 2
case _:
return
if self.body[offset:] == jump and len(self.body[:offset]) % alignment == 0:
if self.body[offset:] == jump and offset % alignment == 0:
self.body = self.body[:offset]
self.holes.remove(hole)

Expand Down