Repository navigation
gh-116180: check if globals is NULL and set error in run_eval_code_obj() #116637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
9635b76
check if gobals is null
ngr-ilmarh 3e97671
make NULL check earlier
ngr-ilmarh 348d895
Merge branch 'main' into fix-issue-116180
259034c
PEP-7
ngr-ilmarh 85d9f47
Merge branch 'main' into fix-issue-116180
cf578bd
Merge branch 'main' into fix-issue-116180
bba6927
Merge branch 'main' into fix-issue-116180
1b5fe4c
Squashed commit of the following:
ngr-ilmarh a016a54
Squashed commit of the following:
ngr-ilmarh 173b9ce
Merge branch 'fix-issue-116180' of https://github.com/NGRsoftlab/cpyt…
ngr-ilmarh 86c6e57
Merge branch 'main' into fix-issue-116180
ngr-ilmarh 7503772
change if null to assert
ngr-ilmarh f175046
Revert "change if null to assert"
ngr-ilmarh dcab696
bring back error message instead of assert
ngr-ilmarh 9532797
return error instead of segfault and test it
ngr-ilmarh ee0fd8a
Merge branch 'python:main' into fix-issue-116180
7eca26f
Merge branch 'python:main' into fix-issue-116180
08b5c3a
Update Python/pythonrun.c
23b9fe6
Update Modules/_testcapi/pyrun.c
acc7eb3
Merge branch 'python:main' into fix-issue-116180
09c71a9
Merge branch 'python:main' into fix-issue-116180
806d21c
refactor unittests through helper
ngr-ilmarh 907c86d
fix closeit test when expect exception global == NULL
ngr-ilmarh af9e9fc
Merge branch 'python:main' into fix-issue-116180
56f0d3c
refactor python test, add some error handling to module init
ngr-ilmarh b1d7ab2
fix lost bracket
ngr-ilmarh f8e29ce
cleanup (and rename)
ngr-ilmarh efe064d
make windows build tests
ngr-ilmarh 8f33e7a
Merge branch 'python:main' into fix-issue-116180
296705a
next round of refactoring
ngr-ilmarh cd58eb6
Merge branch 'python:main' into fix-issue-116180
c461bd9
Merge branch 'python:main' into fix-issue-116180
7db13d0
Merge branch 'python:main' into fix-issue-116180
eef557c
Globals must be dict. Fix filename encoding and file closing in the w…
serhiy-storchaka 66646e9
Merge branch 'python:main' into fix-issue-116180
45cab7f
Skip tests with undecodable filename if not supported.
serhiy-storchaka 1716ac6
Add a test for PyRun_StringFlags(). Test globals at the lower level.
serhiy-storchaka 1a9532c
Pass filename as bytes.
serhiy-storchaka 6f0a0a4
Merge branch 'main' into fix-issue-116180
2607806
Merge branch 'python:main' into fix-issue-116180
7f4c496
Merge branch 'main' into fix-issue-116180
5974757
Merge branch 'python:main' into fix-issue-116180
2b4ba12
Update Lib/test/test_capi/test_pyrun.py
serhiy-storchaka aa73f40
Merge branch 'fix-issue-116180' of https://github.com/NGRsoftlab/cpyt…
ngr-ilmarh f6a8ee9
stashed changes
ngr-ilmarh ccf5871
remove renamed files
ngr-ilmarh abeea0a
Enable tests for NULL and non-dict globals.
serhiy-storchaka d579f21
Add tests for a dict subclass.
serhiy-storchaka d3938f5
Merge branch 'main' into fix-issue-116180
4a18dd2
Merge branch 'main' into fix-issue-116180
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
cleanup (and rename)
- Loading branch information
commit f8e29ce732ec15974d2af2a1f364d3c6acf7ccf5
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
erlend-aasland marked this conversation as resolved.
Outdated
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.