Skip to content

gh-116417: Fix make check-c-globals for _testlimitedcapi #116570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 1 commit into from
Mar 10, 2024
Merged

gh-116417: Fix make check-c-globals for _testlimitedcapi #116570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
gh-116417: Fix make check-c-globals for _testlimitedcapi 
* Remove unused '_testcapimodule' global in Modules/_testcapi/unicode.c.
* Update c-analyzer to not use the internal C API in
  _testlimitedcapi.c.
  • Loading branch information
@vstinner
vstinner committed Mar 10, 2024
commit 256fdc6a85436980a5c63a9555f50d0c02ed1517
4 changes: 0 additions & 4 deletions Modules/_testcapi/unicode.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
#include "parts.h"
#include "util.h"

static struct PyModuleDef *_testcapimodule = NULL; // set at initialization

static PyObject *
codec_incrementalencoder(PyObject *self, PyObject *args)
{
Expand Down Expand Up @@ -2098,8 +2096,6 @@ static PyMethodDef TestMethods[] = {

int
_PyTestCapi_Init_Unicode(PyObject *m) {
_testcapimodule = PyModule_GetDef(m);

if (PyModule_AddFunctions(m, TestMethods) < 0) {
return -1;
}
Expand Down
1 change: 1 addition & 0 deletions Tools/c-analyzer/c_parser/preprocessor/gcc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
FILES_WITHOUT_INTERNAL_CAPI = frozenset((
# Modules/
'_testcapimodule.c',
'_testlimitedcapi.c',
'_testclinic_limited.c',
'xxlimited.c',
'xxlimited_35.c',
Expand Down
1 change: 0 additions & 1 deletion Tools/c-analyzer/cpython/ignored.tsv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,6 @@ Modules/_testcapi/heaptype.c - _testcapimodule -
Modules/_testcapi/mem.c - FmData -
Modules/_testcapi/mem.c - FmHook -
Modules/_testcapi/structmember.c - test_structmembersType_OldAPI -
Modules/_testcapi/unicode.c - _testcapimodule -
Modules/_testcapi/watchers.c - g_dict_watch_events -
Modules/_testcapi/watchers.c - g_dict_watchers_installed -
Modules/_testcapi/watchers.c - g_type_modified_events -
Expand Down