Skip to content

DRAFT: limited call inlining #116257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gvanrossum wants to merge 12 commits into from
Closed

DRAFT: limited call inlining #116257

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
472af08
Print the final optimized uop
gvanrossum Mar 2, 2024
aeafc38
First prototype, works for cast(int, x)
gvanrossum Mar 2, 2024
9bf95e4
More cleanup of debug output, and length adjustment
gvanrossum Mar 2, 2024
8939a9a
Tweak debug output
gvanrossum Mar 2, 2024
b0097a0
Fix decrefs in _ADJUST_STUFF
gvanrossum Mar 2, 2024
7579cf3
X{INC,DEC}REF don't escape
gvanrossum Mar 2, 2024
a370161
Refactor call inline logic and support method calls
gvanrossum Mar 2, 2024
087f8d4
Add tests
gvanrossum Mar 2, 2024
215b7c2
Add _GUARD_NOT_METHOD uop
gvanrossum Mar 3, 2024
0136b3a
Deopt if inlined function call finds self != NULL
gvanrossum Mar 3, 2024
b2ef295
Comment out debug print() calls in test
gvanrossum Mar 3, 2024
6c9ed1f
Remove failing assert
gvanrossum Mar 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
X{INC,DEC}REF don't escape
  • Loading branch information
@gvanrossum
gvanrossum committed Mar 2, 2024
commit 7579cf3d5122e0197b456611027a17376024663f
2 changes: 1 addition & 1 deletion Include/internal/pycore_opcode_metadata.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Include/internal/pycore_uop_metadata.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions Tools/cases_generator/analyzer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,11 +332,13 @@ def is_infallible(op: parser.InstDef) -> bool:

NON_ESCAPING_FUNCTIONS = (
"Py_INCREF",
"Py_XINCREF",
"_PyDictOrValues_IsValues",
"_PyObject_DictOrValuesPointer",
"_PyDictOrValues_GetValues",
"_PyObject_MakeInstanceAttributesFromDict",
"Py_DECREF",
"Py_XDECREF",
"_Py_DECREF_SPECIALIZED",
"DECREF_INPUTS_AND_REUSE_FLOAT",
"PyUnicode_Append",
Expand Down