Skip to content

gh-114258: Argument Clinic: refactor getset implementation #116170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erlend-aasland merged 6 commits into from
Mar 4, 2024
Merged

gh-114258: Argument Clinic: refactor getset implementation #116170

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
970e114
Move param guard to param state machine
erlend-aasland Mar 1, 2024
adbe7cb
Override return converter during parsing
erlend-aasland Mar 1, 2024
972d0db
Make mypy happy
erlend-aasland Mar 1, 2024
cde8a6d
Don't use a custom type slot return converter; instead special case t…
erlend-aasland Mar 1, 2024
cecb56a
Update Tools/clinic/clinic.py
erlend-aasland Mar 1, 2024
2806c4e
Merge branch 'main' into clinic/refactor-getset
erlend-aasland Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make mypy happy
  • Loading branch information
@erlend-aasland
erlend-aasland committed Mar 1, 2024
commit 972d0dbd3662e0414af3677f77aaa752b93a34dc
1 change: 1 addition & 0 deletions Tools/clinic/clinic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5280,6 +5280,7 @@ def state_parameters_start(self, line: str) -> None:
if not self.indent.infer(line):
return self.next(self.state_function_docstring, line)

assert self.function
Comment thread
erlend-aasland marked this conversation as resolved.
Outdated
if self.function.kind in {GETTER, SETTER}:
getset = self.function.kind.name.lower()
fail(f"@{getset} methods cannot define parameters")
Expand Down