Skip to content

GH-115060: Speed up pathlib.Path.glob() by skipping directory scanning #116152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
barneygale wants to merge 6 commits into from
Closed

GH-115060: Speed up pathlib.Path.glob() by skipping directory scanning #116152

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f1b5603
GH-115060: Speed up `pathlib.Path.glob()` by skipping directory scann…
barneygale Feb 26, 2024
cbc7002
Also skip initial is_dir()
barneygale Feb 29, 2024
d1f8cae
Fix tests
barneygale Feb 29, 2024
80e384c
Fix tests, attempt 2
barneygale Feb 29, 2024
0b98008
Fix handling of final literal symlink
barneygale Feb 29, 2024
dfc4766
Make follow_symlinks behaviour a bit clearer
barneygale Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix tests, attempt 2
  • Loading branch information
@barneygale
barneygale committed Feb 29, 2024
commit 80e384c38cd492a9e0473ace936f64f06ae4535e
8 changes: 5 additions & 3 deletions Lib/test/test_pathlib/test_pathlib_abc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1997,15 +1997,17 @@ def test_glob_dotdot(self):

@needs_posix
def test_glob_dotdot_posix(self):
p = self.cls(self.base)
P = self.cls
p = P(self.base)
self.assertEqual(set(p.glob("xyzzy/..")), set())

@needs_windows
def test_glob_dotdot_windows(self):
# '..' segments are resolved first on Windows, so
# 'xyzzy' doesn't need to exist.
p = self.cls(self.base)
self.assertEqual(set(p.glob("xyzzy/..")), { p })
P = self.cls
p = P(self.base)
self.assertEqual(set(p.glob("xyzzy/..")), { P(self.base, "xyzzy", "..") })

@needs_symlinks
def test_glob_permissions(self):
Expand Down