Skip to content

gh-113299: Move Argument Clinic CLI into libclinic #115542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
erlend-aasland wants to merge 12 commits into from
Closed

gh-113299: Move Argument Clinic CLI into libclinic #115542

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f064435
Reorganise the `Tools/clinic` directory
AlexWaygood Dec 23, 2023
1b423c1
`black Tools/clinic/libclinic/cli.py --line-length 90`
AlexWaygood Dec 23, 2023
f2d2c86
Add `__all__`
AlexWaygood Dec 23, 2023
3a1eb0e
update PC\winreg.c
AlexWaygood Dec 23, 2023
c5977a5
Fix failing test
AlexWaygood Dec 23, 2023
ac08f0f
Import ClinicError directly from libclinic
erlend-aasland Feb 15, 2024
95a59d7
Address review: add Tools/clinic/__main__.py
erlend-aasland Feb 15, 2024
8b7dde7
Add NEWS
erlend-aasland Feb 15, 2024
7720c66
PUll in main
erlend-aasland Feb 16, 2024
c5bd50a
Pull in main
erlend-aasland Feb 20, 2024
730c3f9
Revert "Address review: add Tools/clinic/__main__.py"
erlend-aasland Feb 20, 2024
230e321
Pull in main
erlend-aasland Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add NEWS
  • Loading branch information
@erlend-aasland
erlend-aasland committed Feb 15, 2024
commit 8b7dde7b34ed692da104c5bbccadd1d1fcbd6d7b
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Tools-Demos/2024-02-16-00-33-14.gh-issue-113299.lqPMAV.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
The Argument Clinic CLI is now invoked as either :program:`python3
Tools/clinic` or :program:`python3 Tools/clinic/run_clinic.py`, as
:file:`Tools/clinic/clinic.py` has been refactored into ``libclinic``.

@vstinner vstinner Feb 21, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The NEWS entry is outdated, there is no __main__.py script.

@erlend-aasland erlend-aasland Feb 21, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh, thanks; the NEWS entry was not part of the commit I reverted. Good catch.

Comment on lines +1 to +3

@erlend-aasland erlend-aasland Feb 21, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The Argument Clinic CLI is now invoked as either :program:`python3
Tools/clinic` or :program:`python3 Tools/clinic/run_clinic.py`, as
:file:`Tools/clinic/clinic.py` has been refactored into ``libclinic``.
The Argument Clinic CLI is now invoked as
:program:`python3 Tools/clinic/run_clinic.py`,
since :file:`Tools/clinic/clinic.py` has been refactored into ``libclinic``.

@vstinner vstinner Feb 21, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I like this NEWS entry.