Skip to content

gh-82062: correctly set module for built-in instance methods in inspect.signature() #115270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 8 commits into from
May 2, 2024
Merged

gh-82062: correctly set module for built-in instance methods in inspect.signature() #115270

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9e6fd0d
gh-82062: correctly set module for built-in instance methods in inspe…
skirpichev Feb 8, 2024
6a383d7
Merge branch 'main' into text_signature-scope-82062
serhiy-storchaka Apr 30, 2024
48936bd
Merge branch 'master' into text_signature-scope-82062
skirpichev Apr 30, 2024
261fda3
Address review: split statement, that fill module_name
skirpichev Apr 30, 2024
62faa57
Address review: expand news entry
skirpichev Apr 30, 2024
af35327
address review: move test
skirpichev Apr 30, 2024
ce4dbf4
Address review: redo news
skirpichev Apr 30, 2024
b5e83fa
Update Misc/NEWS.d/next/Library/2024-02-11-07-31-43.gh-issue-82062.ee…
skirpichev Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address review: expand news entry
  • Loading branch information
@skirpichev
skirpichev committed Apr 30, 2024
commit 62faa574da43d38108e748105a0da141c8c9052a
5 changes: 3 additions & 2 deletions Misc/NEWS.d/next/Library/2024-02-11-07-31-43.gh-issue-82062.eeS6w7.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
Fix :func:`inspect.signature()` to correctly set extension module for
built-in instance methods.
Fix :func:`inspect.signature()` to correctly set extension module for built-in
Comment thread
skirpichev marked this conversation as resolved.
Outdated
instance methods. They lacks ``__module__`` attribute, so we use instead
``__objclass__.__module__`` attribute.