Skip to content

gh-111968: Refactor _PyXXX_Fini to integrate with _PyObject_ClearFreeLists #114899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
corona10 merged 14 commits into from
Feb 10, 2024
Merged

gh-111968: Refactor _PyXXX_Fini to integrate with _PyObject_ClearFreeLists #114899

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
c8a3d39
gh-111968: Refactor _PyXXX_Fini to follow Eric's suggestion
corona10 Feb 2, 2024
944929e
Remove _PyXXX_Fini
corona10 Feb 2, 2024
6ec90f5
nit
corona10 Feb 2, 2024
c4b3f4f
nit
corona10 Feb 2, 2024
c91a3e7
Refactor to use _PyObject_ClearFreeLists
corona10 Feb 2, 2024
16c72bf
nit
corona10 Feb 2, 2024
f4bdc2e
Add comment
corona10 Feb 2, 2024
47976a2
Fix
corona10 Feb 2, 2024
42ba4b9
fix
corona10 Feb 2, 2024
4585c90
Rename _PySlice_ClearCache to _PySlice_ClearFreeList
corona10 Feb 3, 2024
a121247
Address code review
corona10 Feb 3, 2024
845acac
Relocate _PyXXX_ClearFreeList declaration
corona10 Feb 3, 2024
bac40ea
Address code review
corona10 Feb 3, 2024
3f95c67
Merge remote-tracking branch 'upstream/main' into gh-111968-fini
corona10 Feb 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
nit
  • Loading branch information
@corona10
corona10 committed Feb 2, 2024
commit 16c72bfa2b2f843694652983be0aebd843479976
10 changes: 0 additions & 10 deletions Objects/tupleobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -964,16 +964,6 @@ _PyTuple_Resize(PyObject **pv, Py_ssize_t newsize)

static void maybe_freelist_clear(_PyFreeListState *, int);

void
_PyTuple_Fini(PyInterpreterState *Py_UNUSED(interp))
{
// With Py_GIL_DISABLED:
// the freelists for the current thread state have already been cleared.
#ifndef Py_GIL_DISABLED
_PyFreeListState *state = _PyFreeListState_GET();
maybe_freelist_clear(state, 1);
#endif
}

void
_PyTuple_ClearFreeList(_PyFreeListState *state, int is_finalization)
Expand Down