Skip to content

gh-111140: Adds PyLong_AsNativeBytes and PyLong_FromNative[Unsigned]Bytes functions #114886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zooba merged 22 commits into from
Feb 12, 2024
Merged

gh-111140: Adds PyLong_AsNativeBytes and PyLong_FromNative[Unsigned]Bytes functions #114886

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
c86821e
gh-111140: Adds PyLong_AsByteArray functions
zooba Feb 2, 2024
cd6754a
Statics
zooba Feb 2, 2024
bf86f85
Better options handling and tests
zooba Feb 2, 2024
22f3d14
Rework into PyLong_CopyBits
zooba Feb 2, 2024
0dc0bcc
Merge remote-tracking branch 'upstream/main' into gh-111140
zooba Feb 2, 2024
c30e65a
Not static
zooba Feb 2, 2024
9661b65
Add motivating example to tests
zooba Feb 2, 2024
79d4942
Add FromBits functions
zooba Feb 2, 2024
bc9e48c
A test and a const
zooba Feb 2, 2024
b4761be
Space
zooba Feb 2, 2024
043947f
Merge remote-tracking branch 'upstream/main' into gh-111140
zooba Feb 5, 2024
761db5c
Docs
zooba Feb 5, 2024
22c2a64
Merge remote-tracking branch 'upstream/main' into gh-111140
zooba Feb 7, 2024
6e1a89a
Rename to PyLong_AsNativeBytes
zooba Feb 7, 2024
7b44648
Buffer overflow in big endian
zooba Feb 7, 2024
79dd452
Review feedback
zooba Feb 8, 2024
9693afe
_resolve_endianness
zooba Feb 8, 2024
376e358
More reliable test
zooba Feb 9, 2024
1f2cf3a
Doc tweaks
zooba Feb 9, 2024
7f4431d
Merge remote-tracking branch 'upstream/main' into gh-111140
zooba Feb 12, 2024
2649d94
Merge remote-tracking branch 'upstream/main' into gh-111140
zooba Feb 12, 2024
39962de
Switch to Py_ssize_t consistently instead of int and size_t
zooba Feb 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add motivating example to tests
  • Loading branch information
@zooba
zooba committed Feb 2, 2024
commit 9661b65043a56fc9715e75e487519947b8488372
6 changes: 6 additions & 0 deletions Lib/test/test_capi/test_long.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,6 +501,12 @@ def log2(x):
(-(2**256-1), b'\x00' * 31 + b'\x01', 33),
(-(2**256-1), b'\xff' + b'\x00' * 31 + b'\x01', 33),
(-(2**256-1), b'\xff\xff' + b'\x00' * 31 + b'\x01', 33),

# The classic "Windows HRESULT as negative number" case
# HRESULT hr;
# PyLong_CopyBits(<-2147467259>, &hr, sizeof(HRESULT))
# assert(hr == E_FAIL)
(-2147467259, b'\x80\x00\x40\x05', 4),
]:
with self.subTest(f"{v:X}-{len(expect_be)}bytes"):
n = len(expect_be)
Expand Down