Skip to content

gh-112075: Make instance attributes stored in inline "dict" thread safe #114742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DinoV merged 8 commits into from
Apr 22, 2024
Merged

gh-112075: Make instance attributes stored in inline "dict" thread safe #114742

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
048daa7
Make instance attributes stored in inline "dict" thread safe
DinoV Apr 2, 2024
322914f
Insert into dict on store if dict is materialized and other feedback
DinoV Apr 4, 2024
106685a
_PyObject_TryStoreInstanceAttribute -> _PyObject_StoreInstanceAttribute
DinoV Apr 15, 2024
11d450c
Cleanup _PyObject_SetManagedDict, use cst for inline valid flag, fix …
DinoV Apr 16, 2024
29968e0
Refactor del/set into set_or_del_lock_held, and avoid locking on newl…
DinoV Apr 17, 2024
0023395
Handle dict replacement case better
DinoV Apr 19, 2024
8433d25
Decref materialized dict on fail to set
DinoV Apr 19, 2024
ac503e8
Fix missing decref when storing and dict is detached but has been del…
DinoV Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Decref materialized dict on fail to set
  • Loading branch information
@DinoV
DinoV committed Apr 19, 2024
commit 8433d25fa63f396dc40aa5cb7c0d235d31155b8e
1 change: 1 addition & 0 deletions Objects/dictobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6734,6 +6734,7 @@ store_instance_attr_lock_held(PyObject *obj, PyDictValues *values,
dict = make_dict_from_instance_attributes(PyInterpreterState_Get(), keys, values);
if (dict == NULL ||
set_or_del_lock_held(dict, name, value) < 0) {
Py_XDECREF(dict);
return -1;
}

Expand Down