Skip to content

gh-114315: Make threading.Lock a real class, not a factory function #114479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpshead merged 9 commits into from
Jan 25, 2024
Merged

gh-114315: Make threading.Lock a real class, not a factory function #114479

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3620fa4
wip
sobolevn Jan 22, 2024
4b1c4f6
gh-114315: Make `threading.Lock` a real class
sobolevn Jan 23, 2024
427b450
Assert module instead
sobolevn Jan 23, 2024
1a1b4e8
Do not add to module
sobolevn Jan 23, 2024
aa896b1
Update Doc/library/threading.rst
sobolevn Jan 23, 2024
9d30863
Add `lock` to module
sobolevn Jan 23, 2024
ce357a8
Merge branch 'issue-114315' of https://github.com/sobolevn/cpython in…
sobolevn Jan 23, 2024
3311e0a
Simplify the versionchanged wording.
gpshead Jan 25, 2024
b33a71a
Test that threading.Lock cannot be subclassed.
gpshead Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Do not add to module
  • Loading branch information
@sobolevn
sobolevn committed Jan 23, 2024
commit 1a1b4e8638352ebde38b7169fa401f987cf4c5dc
4 changes: 0 additions & 4 deletions Modules/_threadmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1863,10 +1863,6 @@ thread_module_exec(PyObject *module)
if (state->lock_type == NULL) {
return -1;
}
if (PyModule_AddType(module, state->lock_type) < 0) {
return -1;
}
// Old alias: lock -> LockType
if (PyDict_SetItemString(d, "LockType", (PyObject *)state->lock_type) < 0) {
return -1;
}
Expand Down