Skip to content

[3.11] gh-113358: Fix rendering tracebacks with exceptions with a broken __getattr__ (GH-113359) #114118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iritkatriel merged 7 commits into from
Jan 19, 2024
Merged

[3.11] gh-113358: Fix rendering tracebacks with exceptions with a broken __getattr__ (GH-113359) #114118

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8c12e96
gh-113358: Fix rendering tracebacks with exceptions with a broken __g…
perrinjerome Jan 16, 2024
67ac054
Address review comments
perrinjerome Jan 17, 2024
2c882e0
Apply suggestions from code review
iritkatriel Jan 17, 2024
a4613e2
fix reference leak, after PyErr_Fetch we own the references
perrinjerome Jan 17, 2024
25d62fb
move PyList_New as suggested
perrinjerome Jan 19, 2024
618d128
fixup! move PyList_New as suggested
perrinjerome Jan 19, 2024
d72e989
address review comments
perrinjerome Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review
  • Loading branch information
@iritkatriel
iritkatriel authored Jan 17, 2024
commit 2c882e08d8ce96fd3e446a66234f6d9d4c122d05
4 changes: 2 additions & 2 deletions Python/pythonrun.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1214,11 +1214,11 @@ get_exception_notes(struct exception_print_context *ctx, PyObject *value, PyObje
}
note = PyUnicode_FromFormat("Ignored error getting __notes__: %R", errvalue);
if (!note) {
Py_XDECREF(*notes);
Py_DECREF(*notes);
goto error;
Comment thread
perrinjerome marked this conversation as resolved.
}
Comment thread
perrinjerome marked this conversation as resolved.
if (PyList_SetItem(*notes, 0, note) < 0) {
Py_XDECREF(*notes);
Py_DECREF(*notes);
goto error;
Comment thread
perrinjerome marked this conversation as resolved.
}
}
Expand Down