Skip to content

GH-113655: Lower the C recursion limit on various platforms #113944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markshannon merged 15 commits into from
Jan 16, 2024
Merged

GH-113655: Lower the C recursion limit on various platforms #113944

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
b797d8c
Lower recursion limit for address sanitizer
markshannon Jan 11, 2024
0f11e21
Further lower C recursion limit for address sanitizer.
markshannon Jan 11, 2024
ea12238
Account for GCC when testing for address sanitizer
markshannon Jan 11, 2024
c5d0a50
Give address sanitizer build a bit more C recursion depth
markshannon Jan 11, 2024
eaadfd0
Revert change to test
markshannon Jan 11, 2024
82acac8
Remove COMPILER_STACK_FRAME_SCALE and tweak recursion limits
markshannon Jan 11, 2024
3f3ec46
Lower C recursion limit for s390 back to 1000.
markshannon Jan 11, 2024
cc149d8
Adjust a couple of tests
markshannon Jan 11, 2024
4a22c7e
Add a bit more info to the faulthandler traceback
markshannon Jan 11, 2024
f4a46b7
Fix whitespace
markshannon Jan 11, 2024
c641fbe
Merge branch 'main' into lower-c-recursion-limit-for-windows
markshannon Jan 11, 2024
1079703
Set recursion limit lower for Windows
markshannon Jan 11, 2024
48ff116
Add news
markshannon Jan 11, 2024
adae6cf
Regenerate global string on Windows
markshannon Jan 12, 2024
1c3e63a
Further lower C recursion limit for s390x
markshannon Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adjust a couple of tests
  • Loading branch information
@markshannon
markshannon committed Jan 11, 2024
commit cc149d86a38823da495805926cf2bef06f00ac9f
2 changes: 1 addition & 1 deletion Lib/test/test_ast.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1126,7 +1126,7 @@ def next(self):
def test_ast_recursion_limit(self):
fail_depth = support.EXCEEDS_RECURSION_LIMIT
crash_depth = 100_000
success_depth = 1200
success_depth = int(support.Py_C_RECURSION_LIMIT * 0.8)
if _testinternalcapi is not None:
remaining = _testinternalcapi.get_c_recursion_remaining()
success_depth = min(success_depth, remaining)
Expand Down
6 changes: 2 additions & 4 deletions Lib/test/test_sys_settrace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3037,10 +3037,8 @@ def test_trace_unpack_long_sequence(self):
self.assertEqual(counts, {'call': 1, 'line': 301, 'return': 1})

def test_trace_lots_of_globals(self):
count = 1000
if _testinternalcapi is not None:
remaining = _testinternalcapi.get_c_recursion_remaining()
count = min(count, remaining)

count = min(1000, int(support.Py_C_RECURSION_LIMIT * 0.8))

code = """if 1:
def f():
Expand Down