Skip to content

gh-113688: fix dtrace build on Solaris - #113814

Merged
gpshead merged 1 commit into
python:mainfrom
kulikjak:Solaris-dtrace-fix
Jan 8, 2024
Merged

gpshead merged 1 commit into
python:mainfrom
kulikjak:Solaris-dtrace-fix

Conversation

@kulikjak

@kulikjak kulikjak commented Jan 8, 2024 •

Copy link
Copy Markdown
Contributor

On systems where object files with DTrace probes need to be modified in-place by dtrace (e.g. Solaris), the build currently fails because new gc.c is not included.

@pablogsal

Copy link
Copy Markdown
Member

Can you describe here how are you testing that the integration works?

@pablogsal

Copy link
Copy Markdown
Member

@ambv Do you want to catch up to see if we can add a dtrace Buildbot? I think we can use the perf Buildbot to track this

@nascheme

nascheme commented Jan 8, 2024

Copy link
Copy Markdown
Member

This change looks correct to me. I haven't tested though.

@gpshead
gpshead merged commit bc71ae2 into python:main Jan 8, 2024
@gpshead

gpshead commented Jan 8, 2024

Copy link
Copy Markdown
Member

I merged this because it looks correct. We really should get buildbot coverage for such a build though...

@kulikjak

kulikjak commented Jan 9, 2024 •

Copy link
Copy Markdown
Contributor Author

Thanks!

@pablogsal sure - I maintain an internal Solaris Python buildbot that does daily builds with our patches applied as well. After the weekend, I noticed builds were failing, found the issue (I already fixed a similar one some time ago via #11194), added the patch, and rebuilt the latest bits without issues.

As for the buildbot coverage, AFAIK, only some platforms need to touch the object files with dtrace, which might be the reason this wasn't found with e.g. Linux buildbots?

BTW, there is a Solaris SPARC worker in the Python buildbot (e.g. https://buildbot.python.org/all/#/builders/742), but it's not in the best state because it never passes the tests. I have several PRs open that should make it green (patches we apply internally); once those get in, it should be much more usable.

kulikjak added a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
(the gcmodule -> gc refactoring broke it)
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
(the gcmodule -> gc refactoring broke it)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
(the gcmodule -> gc refactoring broke it)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants