Skip to content

gh-111926: Set up basic sementics of weakref API for freethreading #113621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
corona10 merged 6 commits into from
Jan 3, 2024
Merged

gh-111926: Set up basic sementics of weakref API for freethreading #113621

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a400a06
gh-111926: Set up basic sementics of weakref API for freethreading
corona10 Jan 1, 2024
5c755a8
fix compiler warn
corona10 Jan 1, 2024
32b612f
fix
corona10 Jan 1, 2024
1662b5d
Update Include/internal/pycore_weakref.h
corona10 Jan 3, 2024
8b75804
Address code review
corona10 Jan 3, 2024
72baa0f
Sort header
corona10 Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Include/internal/pycore_weakref.h 
Co-authored-by: Sam Gross <colesbury@gmail.com>
  • Loading branch information
@corona10 @colesbury
corona10 and colesbury authored Jan 3, 2024
commit 1662b5d03ea087afd4143db015f5b09a1190799e
10 changes: 2 additions & 8 deletions Include/internal/pycore_weakref.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,8 @@ static inline int _is_dead(PyObject *obj)
// be able to "see" the target object even though it is supposed to be
// unreachable. See issue gh-60806.
#if defined(Py_GIL_DISABLED)
Py_ssize_t refcount = Py_REFCNT(obj);
if (refcount == 0) {
// In freethreading CPython, Py_REFCNT is only estimated count,
// so need to check shared refcount value too.
Py_ssize_t shared = _Py_atomic_load_ssize_relaxed(&obj->ob_ref_shared);
return _Py_REF_IS_MERGED(shared);
}
return 0;
Py_ssize_t shared = _Py_atomic_load_ssize_relaxed(&obj->ob_ref_shared);
return shared == _Py_REF_SHARED(0, _Py_REF_MERGED);
#else
return (Py_REFCNT(obj) == 0);
#endif
Expand Down