Skip to content

gh-112205: Support @setter annotation from AC #112922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
corona10 merged 18 commits into from
Dec 13, 2023
Merged

gh-112205: Support @setter annotation from AC #112922

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
488a127
gh-112205: Support `@setter` annotation from AC
corona10 Dec 10, 2023
384d6c1
Update
corona10 Dec 10, 2023
2a8c3de
Apply suggestions from code review
corona10 Dec 10, 2023
0ffa78b
Address code review
corona10 Dec 10, 2023
8e85ab3
nit
corona10 Dec 10, 2023
f3517f9
Prohibit declaration of return type for `getset`
corona10 Dec 10, 2023
323cfc0
Add test
corona10 Dec 10, 2023
30da0cf
Update Tools/clinic/clinic.py
corona10 Dec 11, 2023
1539d11
Address code review
corona10 Dec 11, 2023
d18cd49
Address code review
corona10 Dec 11, 2023
bc373f6
Apply suggestions from code review
corona10 Dec 13, 2023
0cd047b
Use pattern matching
corona10 Dec 13, 2023
c8a035f
Address code review
corona10 Dec 13, 2023
9c66961
fix test
corona10 Dec 13, 2023
06b1cb1
Add test
corona10 Dec 13, 2023
2510a35
Address code review
corona10 Dec 13, 2023
53777df
Update Lib/test/test_clinic.py
corona10 Dec 13, 2023
61f7215
Fix
corona10 Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
  • Loading branch information
@corona10 @AlexWaygood
corona10 and AlexWaygood authored Dec 13, 2023
commit bc373f6bdc31f9093ace9684a847141d076b32cd
4 changes: 2 additions & 2 deletions Tools/clinic/clinic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1971,7 +1971,7 @@ def render_function(
full_name = f.full_name
template_dict = {'full_name': full_name}
template_dict['name'] = f.displayname
if f.kind in (GETTER, SETTER):
if f.kind in {GETTER, SETTER}:
template_dict['getset_name'] = f.c_basename.upper()
template_dict['getset_basename'] = f.c_basename
if f.kind is GETTER:
Expand Down Expand Up @@ -5584,7 +5584,7 @@ def state_modulename_name(self, line: str) -> None:
return_converter = None
if returns:
if self.kind in {GETTER, SETTER}:
fail("neither @getter nor @setter can define return type")
fail(f"@{self.kind.name.lower()} methods cannot define a return type")
ast_input = f"def x() -> {returns}: pass"
try:
module_node = ast.parse(ast_input)
Expand Down