Skip to content

gh-109311: Remove support for non-complex/float types in __complex/float__ #112680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
skirpichev wants to merge 18 commits into from
Closed

gh-109311: Remove support for non-complex/float types in __complex/float__ #112680

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
74005f2
gh-109311: Remove support for non-complex/float types in __complex/fl…
skirpichev Sep 12, 2023
6320ed4
Merge branch 'main' into 109311-remove-ss-in-float-complex-dunders
skirpichev May 31, 2024
47a4622
+ adjust more tests
skirpichev May 31, 2024
9862537
Merge branch 'main' into 109311-remove-ss-in-float-complex-dunders
skirpichev Jul 24, 2024
2646539
Merge branch 'main' into 109311-remove-ss-in-float-complex-dunders
skirpichev May 11, 2025
f024115
Apply suggestions from code review
skirpichev May 11, 2025
8d27a2b
move news
skirpichev May 11, 2025
9c36e32
address review: add to whatsnew
skirpichev May 11, 2025
fedfd28
+1
skirpichev May 11, 2025
bbf976d
+ fix test
skirpichev May 11, 2025
a643516
Merge branch 'main' into 109311-remove-ss-in-float-complex-dunders
skirpichev May 11, 2025
f0b6596
Apply suggestions from code review
skirpichev May 11, 2025
e8bf73f
Merge branch 'main' into 109311-remove-ss-in-float-complex-dunders
skirpichev May 25, 2025
408a061
Merge branch 'main' into 109311-remove-ss-in-float-complex-dunders
skirpichev Oct 10, 2025
bc7cd34
+lint
skirpichev Oct 10, 2025
88e5712
Merge branch 'master' into 109311-remove-ss-in-float-complex-dunders
skirpichev Feb 9, 2026
dc690d4
+ remove from pending-removal-in-future.rst
skirpichev Feb 9, 2026
f9ee814
Merge branch 'main' into 109311-remove-ss-in-float-complex-dunders
skirpichev Feb 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
+ adjust more tests
  • Loading branch information
@skirpichev
skirpichev committed May 31, 2024
commit 47a4622526e82b2e48b66cd8ba65b22ae3a4c26c
15 changes: 3 additions & 12 deletions Lib/test/test_capi/test_complex.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,7 @@ def test_realasdouble(self):
# Test types with __complex__ dunder method
self.assertEqual(realasdouble(Complex()), 4.25)
self.assertRaises(TypeError, realasdouble, BadComplex())
with self.assertWarns(DeprecationWarning):
self.assertEqual(realasdouble(BadComplex2()), 4.25)
with warnings.catch_warnings():
warnings.simplefilter("error", DeprecationWarning)
self.assertRaises(DeprecationWarning, realasdouble, BadComplex2())
self.assertRaises(TypeError, realasdouble, BadComplex2())
self.assertRaises(RuntimeError, realasdouble, BadComplex3())

# Test types with __float__ dunder method
Expand Down Expand Up @@ -112,18 +108,13 @@ def test_imagasdouble(self):
# Test types with __complex__ dunder method
self.assertEqual(imagasdouble(Complex()), 0.5)
self.assertRaises(TypeError, imagasdouble, BadComplex())
with self.assertWarns(DeprecationWarning):
self.assertEqual(imagasdouble(BadComplex2()), 0.5)
with warnings.catch_warnings():
warnings.simplefilter("error", DeprecationWarning)
self.assertRaises(DeprecationWarning, imagasdouble, BadComplex2())
self.assertRaises(TypeError, imagasdouble, BadComplex2())
self.assertRaises(RuntimeError, imagasdouble, BadComplex3())

# Test types with __float__ dunder method
self.assertEqual(imagasdouble(Float()), 0.0)
self.assertRaises(TypeError, imagasdouble, BadFloat())
with self.assertWarns(DeprecationWarning):
self.assertEqual(imagasdouble(BadFloat2()), 0.0)
self.assertRaises(TypeError, imagasdouble, BadFloat2())

self.assertRaises(TypeError, imagasdouble, object())

Expand Down