Skip to content

gh-111964: Implement stop-the-world pauses #112471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericsnowcurrently merged 5 commits into from
Jan 23, 2024
Merged

gh-111964: Implement stop-the-world pauses #112471

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cf85548
gh-111964: Implement stop-the-world pauses
colesbury Nov 25, 2023
71ffa1d
Changes from review
colesbury Dec 7, 2023
4ca1e31
Stop-the-world requests should block new threads.
colesbury Dec 7, 2023
470298f
Update comments and _PyThreadState_Suspend.
colesbury Dec 14, 2023
4f7b6ce
Rename stop-the-world functions
colesbury Dec 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Rename stop-the-world functions
  • Loading branch information
@colesbury
colesbury committed Dec 18, 2023
commit 4f7b6ceeab4f5bd4fe93e75ea92b4424961d928b
8 changes: 4 additions & 4 deletions Include/internal/pycore_pystate.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,14 +164,14 @@ extern void _PyThreadState_Suspend(PyThreadState *tstate);
// them from reattaching until the stop-the-world pause is complete.
//
// NOTE: This is a no-op outside of Py_GIL_DISABLED builds.
extern void _PyRuntimeState_StopTheWorld(_PyRuntimeState *runtime);
extern void _PyRuntimeState_StartTheWorld(_PyRuntimeState *runtime);
extern void _PyEval_StopTheWorldAll(_PyRuntimeState *runtime);
extern void _PyEval_StartTheWorldAll(_PyRuntimeState *runtime);

// Perform a stop-the-world pause for threads in the specified interpreter.
//
// NOTE: This is a no-op outside of Py_GIL_DISABLED builds.
extern void _PyInterpreterState_StopTheWorld(PyInterpreterState *interp);
extern void _PyInterpreterState_StartTheWorld(PyInterpreterState *interp);
extern void _PyEval_StopTheWorld(PyInterpreterState *interp);
extern void _PyEval_StartTheWorld(PyInterpreterState *interp);


static inline void
Expand Down
8 changes: 4 additions & 4 deletions Python/pystate.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2055,31 +2055,31 @@ start_the_world(struct _stoptheworld_state *stw)
#endif // Py_GIL_DISABLED

void
_PyRuntimeState_StopTheWorld(_PyRuntimeState *runtime)
_PyEval_StopTheWorldAll(_PyRuntimeState *runtime)
{
#ifdef Py_GIL_DISABLED
stop_the_world(&runtime->stoptheworld);
#endif
}

void
_PyRuntimeState_StartTheWorld(_PyRuntimeState *runtime)
_PyEval_StartTheWorldAll(_PyRuntimeState *runtime)
{
#ifdef Py_GIL_DISABLED
start_the_world(&runtime->stoptheworld);
#endif
}

void
_PyInterpreterState_StopTheWorld(PyInterpreterState *interp)
_PyEval_StopTheWorld(PyInterpreterState *interp)
{
#ifdef Py_GIL_DISABLED
stop_the_world(&interp->stoptheworld);
#endif
}

void
_PyInterpreterState_StartTheWorld(PyInterpreterState *interp)
_PyEval_StartTheWorld(PyInterpreterState *interp)
{
#ifdef Py_GIL_DISABLED
start_the_world(&interp->stoptheworld);
Expand Down