Skip to content

gh-112417: Fix hardcoded ldconfig to use $PATH - #112418

Closed
fiq wants to merge 8 commits into
python:mainfrom
fiq:fix-hardcoded-ldconfig-path
Closed

fiq wants to merge 8 commits into
python:mainfrom
fiq:fix-hardcoded-ldconfig-path

Conversation

@fiq

@fiq fiq commented Nov 26, 2023 •

Copy link
Copy Markdown

See #112417
ctypes.utils.find_library uses a hard-coded path to /sbin/ldconfig This ensures that it does the right things so long as ldconfig is on the $PATH. This ensures that assumptions around binary locations are removed and will work across all Linux distros (tested on Nix) and custom installs for build tools in CI, user-space installs and other environments.

@ghost

ghost commented Nov 26, 2023 •

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app

bedevere-app Bot commented Nov 26, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app

bedevere-app Bot commented Nov 27, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@Eclips4
Eclips4 requested a review from vadmium February 10, 2024 12:34
@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review stale Stale PR or inactive for long period of time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants