Skip to content

gh-112213: Add @critical_section target directive to Argument Clinic #112232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
corona10 merged 8 commits into from
Nov 18, 2023
Merged

gh-112213: Add @critical_section target directive to Argument Clinic #112232

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c074e16
gh-112213: Support specifying object to lock in AC's @critical_sectio…
corona10 Nov 18, 2023
2af6600
Fix mypy
corona10 Nov 18, 2023
804dddf
Fix test case
corona10 Nov 18, 2023
d2e19bd
Support Py_BEGIN_CRITICAL_SECTION2
corona10 Nov 18, 2023
2679803
nit
corona10 Nov 18, 2023
810588d
Add test case
corona10 Nov 18, 2023
d533e10
nit
corona10 Nov 18, 2023
d65c163
Apply suggestions from code review
corona10 Nov 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
nit
  • Loading branch information
@corona10
corona10 committed Nov 18, 2023
commit 26798034100a223d0b00af8091d4cb4575651373
3 changes: 1 addition & 2 deletions Tools/clinic/clinic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1929,8 +1929,7 @@ def render_function(
template_dict['docstring'] = self.docstring_for_c_string(f)

template_dict['self_name'] = template_dict['self_type'] = template_dict['self_type_check'] = ''
if f.target_critical_section is not None:
template_dict['target_critical_section'] = ','.join(f.target_critical_section)
template_dict['target_critical_section'] = ','.join(f.target_critical_section)
for converter in converters:
converter.set_template_dict(template_dict)

Expand Down